newest master doesn't like vertico when M-x is called about vertico HOT 12 CLOSED

Reported here https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48410

EDIT: Duplicate of https://debbugs.gnu.org/cgi/bugreport.cgi?bug=48404

from vertico.

from vertico.

@minad just a quick note to let you know that i'm again using emacs 28 (today's master, compiled with native comp) and the corfu flicker i had observed (as well as this problem, as expected) is totally gone. i am pretty pleased :)

from vertico.

Ouch, I am seeing this too. I just compiled the recent Emacs master. It seems a new bug got introduced. I am guessing it is this one: emacs-mirror/emacs@1af91d2. Can you please report this via report-emacs-bug and link it here? The bug also occurs with default completion. It is not vertico specific.

from vertico.

I experienced this as well. @minad if nobody submits a bug report before this evening (UTC+1 here), let me know and I will do it.

from vertico.

from vertico.

Sure. I too have to work but I just did a hard rest to a working commit before the one pointed out by @minad, and everything's fine now. :)

from vertico.

from vertico.

(aside: are you using corfu with 28? last time i tried there, navigating the pop-up (corfu-next/previous) made it flicker. as i mentioned, in 27.2 is working smoothly)

corfu is working fine with no flickering for me on GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.18, cairo version 1.16.0) of 2021-05-14.

from vertico.

@jaor I am not observing flicker with Corfu on 28 (current master), similar Linux system as @manuel-uberti's. If you can observably reproduce this, please report it as a regression to the Emacs bug tracker. I am not sure if there have been recent changes which affect frames on Linux or other platforms. At least there has been some long discussion on the mailing list about frame adjustments.

In Corfu there was some issue with Gnome/Cinnamon/other gtk desktops (minad/corfu#17). The workaround in the display code could lead to flicker. On these buggy desktops the flicker problem could be worse. I am not sure about the culprit, either the gtk lib itself or the wm/compositor.

from vertico.

At least the M-x issue seems to be fixed in Emacs master. But the fix that has been chosen shows that something is off in the Emacs development process. There is a discussion and in the end we get a suboptimal solution.

1. First there has been a discussion about not showing or indicating obsolete commands in M-x (Good idea)
2. A patch got applied which removed the obsolete commands (Problematic)
3. There was some pushback
4. A patch got applied which instead annotates the obsolete commands (Better, but why not make this an option? Either hide, annotate or show obsolete commands.)
5. There was some pushback
6. A patch gets applied which adds some version checking on the Emacs version, such that only obsolete commands are hidden which got removed without a new name (Wat?)
7. Then it is noticed that the patch does not work for third party packages and it is even broken for some packages which are part of Emacs and use an "invalid" version string
8. Instead of fixing the issue properly (for example adding an option to customize the treatment of obsolete commands), an ignore-errors is added around the problematic code

😞

EDIT: The bugfix which as been applied seems to be a temporary measure to unbreak master. At least I hope so. In my eyes it would have been better to simply revert the broken patch.

from vertico.

from vertico.