Giter VIP home page Giter VIP logo

Comments (13)

mindstorm38 avatar mindstorm38 commented on August 26, 2024

I will :)
It's not that simple for Microsoft auth but for all other classes it should be feasible!

from portablemc.

mindstorm38 avatar mindstorm38 commented on August 26, 2024

Let me know what do you think of these examples!

from portablemc.

GoodDay360 avatar GoodDay360 commented on August 26, 2024

Some parts are still confused like: Authing both Mojang/Microsoft and JVM args.
I guess to make it easier to use. Maybe you make it into the start option.

start_opts = StartOptions()
start_opts.jvmargs = "xmx2G..."
start_opts.authmojang = (email,password)
start_opts.authmicrosoft = (email) #when start function call open webpage and login like when using PMC normal

Raise error when user put username and auth same time into start options.

from portablemc.

mindstorm38 avatar mindstorm38 commented on August 26, 2024

I added how to change arguments to the documentation.

For the authentication part, it's not how I would do that because what happen if both authmojang and authmicrosoft are set, together with username and uuid. Which will get the priority, it's why I chose to have only one argument auth_session and the user decides what type of session to use. I made something like you suggested in the past and this was really hard to maintain or simply got it to work. By the way, the uuid and username options might be moved to an OfflineAuthSession class in the future to be more consistent.

For now, I only documented Yggdrasil sessions because Microsoft ones are really hard to automate, for example in the CLI there is a minimal web server that is opened temporarily to captures tokens answered by Microsoft, maybe I can move this little web server utility to the API to help devs to support Microsoft auth.

from portablemc.

mindstorm38 avatar mindstorm38 commented on August 26, 2024

Yes, it's the name of the service

from portablemc.

GoodDay360 avatar GoodDay360 commented on August 26, 2024

Anyway, what is AuthDB?
Does it act as a place to save user information or something?
What does it have to do with Yggdrasil?
Can I log in to the Mojang account without AuthDB?

from portablemc.

GoodDay360 avatar GoodDay360 commented on August 26, 2024

Overall can you just give me the simplest example for:

  1. Start Minecraft (any version) with Mojang Account
  2. Start Minecraft (any version) with Microsoft Account
    And do I have to manually set the function to install Java or it will auto-download/install when starting the game if java is not installed?

from portablemc.

mindstorm38 avatar mindstorm38 commented on August 26, 2024

The authentication database is not directly related to Yggdrasil or Microsoft auths, it's a JSON file database where you store auth session once you've logged in, so you don't have to relogin on each start.

I can make an example for Mojang account but microsoft ones are harder, but I will try. If you can install(jvm=True) like the example in API.md it should install JVM

from portablemc.

GoodDay360 avatar GoodDay360 commented on August 26, 2024

Oh I understand now. Anyway I just reinstall my window and noticed that when downloading Minecraft using PMC is so slow it use only 30%->40% of my internet speed. Internet 7MB/s in pmc it use only 1.5MB/s

from portablemc.

mindstorm38 avatar mindstorm38 commented on August 26, 2024

I already made huge improvements to the download API, but it is very complicated to get high performance downloads with Python. It can also be limited by the CDN server

from portablemc.

GoodDay360 avatar GoodDay360 commented on August 26, 2024

I guess you can do multi download process. Like, get all the files list. Split it into half. Start a thread one for download in the first half. Another thread downloads the second half. I don't know if it is possible or not.

from portablemc.

GoodDay360 avatar GoodDay360 commented on August 26, 2024

And one more thing. Since the updated version of patched log4j. When I compile PMC with my launcher it window defender doing flag mark as a virus. I tried to compile without PMC it works find except with PMC 🤷‍♂️.

from portablemc.

mindstorm38 avatar mindstorm38 commented on August 26, 2024

For the parallel download, yes it's how I would do that, but I was wondering if the GIL (global interpreter lock) could slow the download down. But because it's an IO operation, it might be ok, maybe.

For windows defender, I don't know at all how it is supposed to detect viruses, there's nothing in that code that directly refers to the log4j exploit. The only thing that might be detected can be the parts in the file where you can find <XMLLayout /> and <LegacyXMLLayout />.

from portablemc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.