Comments (6)
Evidence for @PaintNinja to indicate it worked prior to this release to actually load files:
https://gist.github.com/LordRalex/3aef9ab3f668bb90d03497cc47c2927c#file-debug-log-L2449 - .43 with Sponge, and AutoPickup loading from it:
https://gist.github.com/LordRalex/a91879a92b3b7e65e3d6099fa93674fa .45 where it fails
from minecraftforge.
So the issue is that your change to actually respect loading errors meant that a previously silently ignored exception was surfaced.
So ya, Jonathing is correct that warning users about non-forge mods in the mods folder WAS an intended feature, but due to the poor design of FML it seems that in actuality it was just silently ignored and people have come to rely on that functionality.
So I just made it log a message and ignore the file, should be working as it was before.
from minecraftforge.
Could you provide a test jar please? The commit you're referencing should not have any impact for your scenario, as it only applies to mod jars that contain an invalid mods.toml. It shouldn't make a difference for jars missing a mods.toml altogether
from minecraftforge.
Since this issue mentions a log with SpongeForge, I am going to assume that you are attempting to load a Sponge plugin with Forge. Since Sponge should load plugins from the plugins
folder, there's really no reason for you to be putting your Sponge plugin in the mods
folder.
If I recall correctly, Forge not playing nice with non-Forge mods in the mods folder is intended behavior, to attempt to inform the user that they might not be using the correct build of a mod for Forge (i.e. they might've downloaded a Fabric mod and are trying to use it on Forge). I invite @PaintNinja to correct me if I'm wrong.
Regardless, here's WorldEdit for Sponge. I just yoinked it off of Ore since it's one of their most downloaded plugins: WorldEdit 7.2.16+6534-206eb4
from minecraftforge.
You can use any jar that doesn't have a mods.toml. The TestPlugin.jar
in the logs is just a small jar I built locally and isn't hosted anywhere. I just tried with https://ore.spongepowered.org/Yeregorix/AutoPickup/versions/1.2.0 and I get the same error. You can also use WorldEdit yes.
from minecraftforge.
I have similar issue when including FabricMC mods in the folder or FeatureCreep mods when they end in .jar. FeatureCreep (which I am the lead dev of) looks for custom jars in the mods folder and since CurseForge only allows a small number of extensions there is little choice than having them set .jar and other abstraction layers may have issues as well especially since most modpack formats default to the mods folder.
It provides an error on the screen saying invalid modfile but does not let me continue loading like before.
This only happens on version 49.0.45 and above or on 1.20.6 versions. On 49.0.43 and before it works fine.
at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModLoader.<init>(ModLoader.java:98)
at LAYER PLUGIN/[email protected]/net.minecraftforge.fml.ModLoader.get(ModLoader.java:130)
I know you did some changes around lines 96-98 and that is where it is crashing from
from minecraftforge.
Related Issues (20)
- [SECURITY] Vulnerabilities in Forge 47.2.X HOT 1
- [1.20.6] ATs still use SRG mappings HOT 1
- Vault Block crash in 1.20.6 HOT 2
- [1.20.6] getArmorTexture bug HOT 1
- [1.20.6] DeferredRegister for ArmorMaterial is broken HOT 2
- update mcp for 1.20.6 HOT 1
- finalizeSpawn() is always passed null SpawnGroupData
- forge 1.20.6 patches the stencil enable into the wrong spot
- [1.20.6] Shield does not work HOT 3
- Forge Crashes HOT 1
- The game crashed whilst unexpected error Error: java.lang.IllegalStateException: Missing registry: ResourceKey[minecraft:root / minecraft:dimension_type] HOT 1
- [1.20.6] Potion Brewing is broken
- [1.20.6] Cancelling MobSpawnEvent.FinalizeSpawn for a spawner causes NullPointerException
- 1.20.1 Forge Redstone differs from Vanilla and Fabric HOT 3
- [1.20.6] Game crashes when reloading a world that uses custom placed features HOT 2
- The drawing order of page numbers in CreativeModeInventoryScreen is incorrect HOT 3
- EntityInteractSpecific event isn't posted on the server side anymore HOT 1
- [1.20.6] Forge fails to load brigadier classes in time for RegisterCommandsEvent leading to mod crashes HOT 2
- LivingAttackEvent working inconsistently with Entity.setDeltaMovement when the event is cancelled.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from minecraftforge.