Comments (4)
In Step 3, if nodes 2 & 3 would also grant the lock than quorum would be met and the lock would be granted (even if node 4 is still in blocked/network error state).
There is a (small) backoff window before trying to lock again, depending on timing it could be suboptimal in terms of number of messages, but it would not lead to incorrect behavior, right?
from dsync.
@fwessels, the lock mentioned in step 3 on "test' is different from the lock mentioned in step 1. I am not referring to the lock messages that appear out of retrying due to previous attempts at failing to lock. Does it make sense now?
from dsync.
I see, this order of events can indeed happen.
from dsync.
While the above order of events can maybe lead to not the most efficient way of dealing with it, it should not lead to incorrect behaviour (bugs).
One can also think of other scenarios that show correct behaviour but are suboptimal in terms of eg number of messages exchanged. While it is probably possible to optimize these scenarios it would complicate the code (and hence maybe introduce new bugs), so I think this is not worth the effort (and risk).
from dsync.
Related Issues (11)
- tests: go test -race reports races. HOT 1
- Add profiling support for dsync HOT 1
- README: Don't recommend redis distlock HOT 4
- Scalability (curiosity) HOT 3
- Typo in Motivation section for minio server command line HOT 1
- Fix all golint issues on dsync HOT 7
- dsync: chaos test fails with "Timed out" HOT 1
- Is there any support for Async / callback instead of blocking to acquire lock ? HOT 2
- Go module: github.com/minio/dsync/[email protected]: go.mod has non-.../v2 module path "github.com/minio/dsync" (and .../v2/go.mod does not exist) at revision v2.0.0 HOT 1
- Update documentation HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dsync.