Giter VIP home page Giter VIP logo

Comments (7)

samselikoff avatar samselikoff commented on May 15, 2024

I like this api:

// tests/factories/contact.js
import EP from 'ember-pretenderify';

export default EP.Factory.define({

  name: EP.faker('name'),

  age: 20,

  email: function(self, n) {
    return `person${n}@test.com`;
  },

  admin: function(self) {
    return self.age > 30;
  }

});

I'm using Factory.define rather than .extend because this is not going to be an Ember.Object.

from ember-cli-mirage.

marcioj avatar marcioj commented on May 15, 2024

Hi Sam, I found pretty interesting the factory idea. One question: Are you planning in add mixins/trait and factory inheritance support?

from ember-cli-mirage.

samselikoff avatar samselikoff commented on May 15, 2024

I'm basically trying to copy as much of the factory_girl API as possible. Traits are definitely on the roadmap...what are mixins in this context? And inheritance support should absolutely be supported, thanks for mentioning.

from ember-cli-mirage.

marcioj avatar marcioj commented on May 15, 2024

Great! By mixins I meant the same concept of traits in factory girl.
I was thinking about some API which could also support traits and factory inheritance, this is what comes to my mind. Just a suggestion :)

import { define, build } from 'ember-pretenderify/factory';

function add(a,b) {
  return a+b;
}

export default define(function() {
  this.factory('order', function() {

    this.customer_name = 'Mr foobar';
    this.delivery_address = 'foobar street';
    this.items = [];
    this.status = 'new';

    this.total = function() {
      return this.items.map(function(item) {
        return item.price;
      }).reduce(add, 0);
    };

    this.factory('order_with_itens', function() {
      this.items = [build('order_item')];
    });
  });

  this.trait('pending_payment', function() {
    this.status = 'pending';
  });
});

// usage
order = build('order');
order.delivery_address; // 'foobar street'
order = build('order', delivery_address: 'other address');
order.delivery_address; // 'other address'
order = build('order_with_items');
order.items.length // 1
order = build('order', 'pending_payment');
order.status // 'pending'

Basically a conversion of factory girl's DSL to javascript.

from ember-cli-mirage.

samselikoff avatar samselikoff commented on May 15, 2024

@marcioj gotcha, yep I definitely am planning on doing traits.

You can see the API I started out with here: https://github.com/samselikoff/ember-pretenderify/blob/add-factories/tests/factories/contact.js. It's working in that branch. You can see the use here. I'm not sure we need the build/create distinction here - I think I'm going to use create for now, since it adds them directly to the store.

I'm also planning on adding Faker.js so you can do things like

name: EP.Faker('name')

The total example you have above is interesting, wouldn't that be something that already lives on the model? The purpose of these factories is just to get data into the server's "database".

You can look at the tests for factories and create to see what functionality I currently have.

I haven't implemented factory inheritance yet but it's on the roadmap. I'd like it to match the typical Ember CLI inheritance workflow, i.e. import blah from './blah'; export blah.extend, even though factories aren't going to beEmber.Objects.this.factory(name)` requires some global register and I'd prefer not to do that, I just want to load the factories into the server definition (you can see how I'm doing it currently here).

Thoughts?

from ember-cli-mirage.

samselikoff avatar samselikoff commented on May 15, 2024

Created additional issues for the rest of the items, wanted to go ahead and cut a release with the current functionality

from ember-cli-mirage.

marcioj avatar marcioj commented on May 15, 2024

Great work @samselikoff! This is definitely the way I would like to mock data in ember tests.

from ember-cli-mirage.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.