Giter VIP home page Giter VIP logo

Comments (4)

evol262 avatar evol262 commented on August 28, 2024 1

Yep, the missing d is a typo. I'l get a patch up for it in a couple minutes. cri-dockerd.sock is correct.

Thanks for checking @neolit123 :D

from cri-dockerd.

neolit123 avatar neolit123 commented on August 28, 2024

thanks!

from cri-dockerd.

afbjorklund avatar afbjorklund commented on August 28, 2024

We already have hardcoded cri-docker.sock everywhere, since it was the values in the systemd units.

i'm assuming that the missing d is a typo?

Since dockerd uses docker.sock, it didn't come as a shock when cri-dockerd was using cri-docker.sock

If I recall correctly, the default value was still dockershim.sock until later on in the project. (902dde6)

It can be changed, but you are making this harder...

Will update path to unix:///var/run/cri-dockerd.sock

from cri-dockerd.

afbjorklund avatar afbjorklund commented on August 28, 2024

@evol262

Note that the name of the service no longer matches the name of the socket. If it matters at all.

https://github.com/Mirantis/cri-dockerd/blob/master/packaging/systemd/cri-docker.service

i.e. maybe it should also be "cri-dockerd" ?

sudo systemctl enable cri-dockerd.socket
sudo systemctl start cri-dockerd.socket

Would be good to fix that too now (0.2.1), if so...

from cri-dockerd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.