Giter VIP home page Giter VIP logo

Comments (4)

chauncyAAA avatar chauncyAAA commented on August 28, 2024

core/logs.go

// ReopenContainerLog reopens the container log file.
func (ds *dockerService) ReopenContainerLog(
_ context.Context,
_ *runtimeapi.ReopenContainerLogRequest,
) (*runtimeapi.ReopenContainerLogResponse, error) {
return nil, fmt.Errorf("docker does not support reopening container log files")
}

from cri-dockerd.

nickvth avatar nickvth commented on August 28, 2024

Why is this closed? Still have this on RKE clusters with k8s 1.24.8 and cri-dockerd enabled
Or is there a fix/workaround?

from cri-dockerd.

evol262 avatar evol262 commented on August 28, 2024

@nickvth because a fix from Rancher was merged in as part of #38. I'll check the metrics server for 1.24.8 to see if they changed what they're expecting here, because Docker has never been able to re-open container logs, including in the in-tree dockershim

from cri-dockerd.

nickvth avatar nickvth commented on August 28, 2024

@evol262 fixed when setting container-log-max-size to the same size as docker daemon max-size log opts.

from cri-dockerd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.