cri-dockerd 0.2.2 self-identifies as 0.2.1 about cri-dockerd HOT 4 CLOSED

Thanks! Updated binaries are uploaded.

from cri-dockerd.

Thanks! Updated binaries are uploaded.

Thanks, but I find it a bit concerning that you are replacing already released files with new versions, and especially that the builds no longer correspond to the tagged commit. I would have thought the existing files would be left in-place, and the next release would just be tagged/updated correctly.

It is of course not a big deal if this is the only change, but I expected releases to always comes from CI and not being built in an unknown environment.

from cri-dockerd.

The tag was also replaced so it lines up, though I don't expect this to happen again. The actual cause wasn't just version.go not being updated, but also that the changes in #54 clobbered the variables set as part of the Makefile.

There's a patch up in #76, and there'll be another patch to default to cni as a network backend with 1.24 out the door, followed by a release of 0.2.3

The builds are done from the Dockerfiles VERSION=... make static|deb|rpm. It's not done from CI because it's maddeningly, mindboggling slow to generate that many DEBs/RPMs inside containers inside Github runners.

The static builds could be, at least.

from cri-dockerd.

The tag was also replaced so it lines up

I didn't see this (and still don't); when I check version.go at the v0.2.2 tag on Github, then it still says 0.2.1: https://github.com/Mirantis/cri-dockerd/blob/v0.2.2/cmd/version/version.go#L4-L5

Maybe you only updated the tag locally and didn't push it to Github?

Anyways, thanks a lot for keeping the project updated!

from cri-dockerd.