Giter VIP home page Giter VIP logo

Comments (4)

rafalp avatar rafalp commented on July 22, 2024

CC @patrys and @salwator

from ariadne.

rafalp avatar rafalp commented on July 22, 2024

We've discussed this yesterday, and new API we would like to have looks like this:

from ariadne import Schema, gql, start_simple_server

type_defs = gql("""
    type Query {
        people: [Person!]!
    }

    type Person {
        firstName: String
        lastName: String
        age: Int
        fullName: String
    }

    scalar Datetime
""")

schema = Schema(type_defs)

query_resolvers = schema.type("Query")


@query_resolvers.register("people")
def resolve_people(*_):
    return [
        {"first_name": "John", "last_name": "Doe", "years": 21},
        {"first_name": "Bob", "last_name": "Boberson", "years": 24},
    ]


people_resolvers = schema.type("People")
people_resolvers.alias("age", "years")


@people_resolvers.register("fullName")
def resolve_person_fullname(person, *_):
    return "%s %s" % (person["first_name"], person["last_name"])


start_simple_server(schema)

from ariadne.

rafalp avatar rafalp commented on July 22, 2024

We've stepped back from above to keep modularization easy and expectable. Instead we are moving from dict as lowest level of abstraction for mapping resolvers (but that would be easy to add back if we'll decide to do so).

New approach replaces resolver dicts with ResolverMap objects and moves resolver assignment to those objects:

person = ResolverMap("Person")
person.alias("age", "years")


@person.field("fullName")
def resolve_person_fullname(person, *_):
    return "%s %s" % (person["first_name"], person["last_name"])


# Create and run dev server that provides api browser
start_simple_server(type_defs, [query, person])  # Visit http://127.0.0.1:8888 to see API browser!

This has few nice advantages:

  • We no longer rely if isinstance() checks around code for type-specific handling logic.
  • We get nice separation and extensitivity via ResolverMap and potentially Scalar, DateTimeScalar, Interface or such.
    -It's super easy to include extra type-specific validation logic for catching dev mistakes.

from ariadne.

rafalp avatar rafalp commented on July 22, 2024

I've updated original post, in coming days I'll try to find time to get this PR to mergeable state.

from ariadne.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.