Giter VIP home page Giter VIP logo

Comments (2)

pawelrubin avatar pawelrubin commented on July 22, 2024

This is achievable via Protocol.

@rafalp Let me know if the definitions below would be correct.

class Resolver(Protocol):
    def __call__(self, obj: Any, info: GraphQLResolveInfo, **kwargs: Any) -> Any:
        pass


class TypeResolver(Protocol):
    def __call__(self, obj: Any, *_: Any) -> Optional[str]:
        pass

If so, I'd love to make a contribution.

EDIT
There are already some decent type definitions in graphql-core.

# Note: Contrary to the Javascript implementation of GraphQLFieldResolver,
# the context is passed as part of the GraphQLResolveInfo and any arguments
# are passed individually as keyword arguments.
GraphQLFieldResolverWithoutArgs = Callable[[Any, GraphQLResolveInfo], Any]
# Unfortunately there is currently no syntax to indicate optional or keyword
# arguments in Python, so we also allow any other Callable as a workaround:
GraphQLFieldResolver = Callable[..., Any]

# Note: Contrary to the Javascript implementation of GraphQLTypeResolver,
# the context is passed as part of the GraphQLResolveInfo:
GraphQLTypeResolver = Callable[
    [Any, GraphQLResolveInfo, "GraphQLAbstractType"],
    AwaitableOrValue[Optional[Union["GraphQLObjectType", str]]],
]

However, GraphQLFieldResolver could also be more accurate.

Should ariadne import types from graphql-core or use its own definitions?

Anyway, the Resolver type definition could be rewritten to:

class Resolver(Protocol):
    def __call__(self, obj: Any, info: GraphQLResolveInfo, **kwargs: Any) -> Any:
        pass

from ariadne.

rafalp avatar rafalp commented on July 22, 2024

We could use type definitions from graphql-core and and run extra checks on our side at type's definition time.

from ariadne.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.