Comments (10)
Alright, I started to look at that:
will require more detailed investigation as it is converted to an integer at a place that makes it somewhat hard to change.nevermind, fixed: 1d24c1b- the
local
key in tag isn't in the schema at all, can you give more details on how you got the warning, please?
from pymisp.
It is a bug on MISP side, that should be handled as a boolean, and not 0/1. It will be fixed in MISP asap.
from pymisp.
FYI, the fix is now on develop and will go into the release later today.
from pymisp.
@Rafiot - Can you please look into it. Thanks.
from pymisp.
The events generated by PyMISP work just fine on MISP, so it is probably more an issue with the schema itself.
from pymisp.
ok, update on that: PyMISP to_json
returns a blob that is compatible with what MISP expects (float or int) when the schema says string.
We could consider to add a method that casts the int/float to str, but the default will stay the same for backward compatibility reasons. What is your use-case?
from pymisp.
Thanks @Rafiot. Our requirement is to export the MISP event and ensure it passes the MISP standard schema before passing it on to the data pipeline for subsequent processing. At every stage of the pipeline, the very thing they do is schema validation again.
from pymisp.
- Thanks @Rafiot for fixing the timestamp. LGTM.
- When an event is downloaded using MISP WebUI, the tag's
local
attribute is number (i.e.int
). Whilst the APIevent.to_json()
returns it asstr
. Yes thelocal
key isn't in the schema, however we've added it for our use case to match with the WebUI downloaded event. We expect the outcome to be the same whether an event is d/l using WebUI or using API. It's not a show stopper, but good to have consistency.
from pymisp.
@Rafiot I want to extend this. What is the reason for the blanket _int_to_str(to_return)
call inside to_dict
method in AbstractMISP.py? As a result, Tag's local
values (0 and 1) get changed into string
values ("0" and "1") , which is unexpected.
P.S
I have added a fix for this #1171
from pymisp.
MISP v2.4.187 got an upstream fix for this. Now local values are represented as true
and false
.
from pymisp.
Related Issues (20)
- AttributeError: module 'pymisp' has no attribute 'EmailObject' when doing from pymisp import * HOT 2
- PyMISP.toggle_warninglist() sends GET method HOT 4
- PyMISP.disable_warninglist() doesn't disable, but toggle instead HOT 1
- Is it possible to change the timestamp for an attribute programatically? HOT 2
- IBM SOAR application with MISP error HOT 4
- upload_stix function return nothing when using in-memory file
- Support X-MISP-AUTH Header
- Proofpoint_tap.py script error HOT 1
- Tag for v2.4.189? HOT 4
- PyMISP and MISP version mismatches HOT 3
- PyMISP and MISP version mismatch HOT 2
- Object dropped due to validation for Event HOT 3
- Error with urllib3_with_brotli HOT 10
- Can't get search() to return attachments that have been included inside a object (e.g. report object attachment files) HOT 2
- Duplicated devices on GLPI HOT 1
- published=False returns published events HOT 2
- "The info field of the new event is required." returned when attempting to create a new event HOT 1
- Error while having the newest version of PyMISP: " This class is deprecated, use PyMISP instead warnings.warn('This class is deprecated, use PyMISP instead', FutureWarning" HOT 4
- Can't untag numeric tag name (str('1')) from an event HOT 2
- Sync Sightings: add sightings discards sighting UUID passed on HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pymisp.