`o.before()` within a `o.spec` still runs even when no tests are running about ospec HOT 4 OPEN

Hi @gilbert thanks for the report. This should be fixable, I'll look into a solution.

from ospec.

I ran into this myself. Has there been any progress? Not familiar with ospec codebase, but I might be able to find time to look into this if you don't have time @pygy. Let me know if you have any ideas for the solution already.

from ospec.

May be other considerations I am missing, but updating this line to the following seems to work:

only.length === 0 ||
	Object.values(spec.children).some(
		x => x instanceof Task && only.includes(x.fn)
	) ? spec.before : [],

Could use Set for performance but since the number of only is typically 1 or small, it shouldn't matter for most use cases.

from ospec.

Any chance we can get @jonahx's fix into a new release? 👀

from ospec.