PostRepository Uses Repository.Name in the POST request URL about sharpbucket HOT 5 CLOSED

The repository json actually has a property called slug.

For my own project I use a custom Repository POCO for this.

namespace BitbucketPocos
{
    public class Repository
    {
        public Project project { get; set; }
        public string scm { get; set; }
        public bool? has_wiki { get; set; }
        public string description { get; set; }
        public Links links { get; set; }
        public string fork_policy { get; set; }
        public string language { get; set; }
        public string created_on { get; set; }
        public string full_name { get; set; }
        public bool? has_issues { get; set; }
        public Owner owner { get; set; }
        public string updated_on { get; set; }
        public ulong? size { get; set; }
        public bool? is_private { get; set; }
        public string name { get; set; }
        public string uuid { get; set; }
        public string slug { get; set; }
    }
}

Meanwhile you could also translate the repository to a slug using the code I used in this PR here: https://github.com/MitjaBezensek/SharpBucket/pull/70/files

from sharpbucket.

@mnivet Now that Repository has a slug property, should this be cleaned up? Looking at the API, it seems that all of the repo methods want the slug, not the name. Probably all of the parameter names should be changed from repository to slug or repositorySlug to make this clear, and the methods themselves should use the slug property. I can work on a PR.

from sharpbucket.

Actually, the API can take the slug or the {UUID}.

from sharpbucket.

When you want to create a new repository (which is the goal of PostRepository) you can't know the UUID, and it's not your duty to guess how names should be transformed to be a valid slug

The pull request #70 done by @anh-duc-le is now re-integrated and do what was needed :
transform the repository name into a slug (code that is called behind the PostRepository method)

So maybe there is still some clean up re-factoring to perform to rename parameter names from repository to repositorySlug like you suggest @asherber
But since the fix is re-integrated let's close that issue and I let you open another one if you think that doing some parameter renaming is really necessary

from sharpbucket.

Thanks, I'll take a closer look at the code, but it seems to me that the RepositoryResource methods could all do with a little cleanup to make their intent cleaner.

from sharpbucket.