mitmproxy saves failed CONNECT request URLs to HAR files incorrectly about mitmproxy HOT 6 CLOSED

Could you provide an example dump file that exhibits this behavior?

from mitmproxy.

The mitmproxy flows don't seem to save this request, but here is an example HAR dump:

test.har.zip

from mitmproxy.

Hello! I am a first-time contributor to mitmproxy and new to open-source in general, so I apologize in advance if something I say does not make sense.

My approach to this issue is to check if the request method is CONNECT, in which case the url field can be set to https://host/ (since this behavior is seen only in case of HTTPS and not HTTP) instead of host:port, which is the default url of the CONNECT method.

Also, does the url field have to be of the form https://host/ or does https://host:port/ also work?

Please let me know if this approach makes sense, so I can open a pull request for the same. Thank you!

from mitmproxy.

@basedBaba I think your approach makes sense! I can test your PR if you make one to check if it works on my end

Also, does the url field have to be of the form https://host/ or does https://host:port/ also work?

The HAR spec says that the url field is the "absolute URL" of the request, so I would go with the https://host:port/ form. We can also have more information about the request this way

from mitmproxy.

@DaniElectra Thank you for the assistance!

I have opened a PR for review.

from mitmproxy.

Fixed by #6599 👍

from mitmproxy.