Search or highlight by body contents. about mitmweb HOT 4 OPEN

any update on this feature?

from mitmweb.

there are several ways to solve this problem:

1. send the content with the flow to the client, so we can search the content on the client side
2. send the filter to the server with a request and get the a list with matched flows back, do that on every flowupdate, flowadd,... event
3. send the filter to the server with a request and get the a list with matched flows back, the server should also store the filters from the client and adds to each flow a field on which filters that flow matches
4. send the filter to the server, the server adds an information to all flows -> flows will be automatically updated and so we have the needed information.

what do you think? do you have more ideas ?

from mitmweb.

Thanks for the write-up @cle1000.
@cortesi: Content search is maybe one of the most tricky parts we have - what are you thoughts on this? This is also a feature that does not really translate to our static viewer, so I'd be interested to hear your thoughts.

My five cents: 1 is a possible resource hog - not what we want. 3 and 4 are nice solutions, but this implies keeping state on the server and interleaving filter/highlight logic with the whole flow list components. I'm a bit a fraid that this ends up as spaghetti. 2 is not really pretty, but leaves all flow content searching in an isolated place/API. The main issue here would be that once we receive a flow update, we need to do an asynchronous request to the server, leaving a small time period in between where we don't know how to handle the flow. for positive/"show only" filters that probably wouldn't be too bad, as they just stay hidden for a bit longer. For negative filters, we'd have flows show up incorrectly and then quickly disappear again - that sucks, but might be enough of an edge case that we don't need to care about it.

from mitmweb.

@cortesi: what do you think? i should implement this in the next two weeks as my "last" gsoc feature :)

from mitmweb.