Algorithm enum needs to be moved from JwtSigner impls about openid-connect-java-spring-server HOT 10 CLOSED

Each is relevant to the specific implementation, e.g., HMACSHA256 has no relevance to a RSA Signer.

from openid-connect-java-spring-server.

So doesn't belong in an interface.

from openid-connect-java-spring-server.

No, these values are defined by the JWS specification in a central list and they need to be used as common keys to select signers. They need to be coalesced into a central Enum class.

from openid-connect-java-spring-server.

We should discuss out of band.

from openid-connect-java-spring-server.

The issue is that there are several places in the code where (in future) we will need to have services that can get a JwtSigner by algorithm name. In order for that to work smoothly, the algorithm name should be accessible from the interface, not from the implementations. That way I can say "JwtSigner currentSigner = signerService.getSignerByAlgorithm("HMACSHA256")". It would also be useful to be able to retrieve the algorithm name from a JwtSigner whose implementation is unknown.

For right now we are just using a default signer (the RSA one), but further on we will need to be able to retrieve a signer corresponding to the Client's registered preferred algorithm.

from openid-connect-java-spring-server.

We should discuss offline as the spec permits multiple instances of a specific signer algorithm as i read it

from openid-connect-java-spring-server.

Yes it does, and this doesn't restrict that capability.

from openid-connect-java-spring-server.

We still need to be able to choose a signer based on the Client's preferred algorithm. signerService.getSignerByAlgorithm() can return a list, and we can have some rule for determining which one to use if we have several. But either way, we need that capability.

from openid-connect-java-spring-server.

I recognized some needed refactoring an code clean up across the signers responding to issue #5 as I learned more about creating Spring beans writing the client Authentication Filter. My advice would be to the keep the Algorithm enums where they are as they are specific to the individual signers in the purpose that they serve: They map the Spec defined names to the Java Standard cryptographic algorithm names for each respective signer. Each of the signers use the ENUM in their respective afterPropertiesSet-method to instantiate an instance of the algorithm by which the respective class will sign and verify signatures. I do believe you both are correct an enum needs to be in the interface, though. The afterPropertiesSet interface supports an exception being thrown for implementations of this method, and an exception will be thrown if an spec algorithm name is submitted not matching one supported by the signer.

from openid-connect-java-spring-server.

Refactored to JwsAlgorithm enum

from openid-connect-java-spring-server.