Custom logger support about mixpanel-node HOT 6 CLOSED

Hi, @tdumitrescu ,

Is there any help I could provide to get my pull request merged into the master branch?

from mixpanel-node.

👍 Sure, there shouldn't be any problem with support for a custom logger passed as an option to mixpanel.init().

from mixpanel-node.

hi, @tdumitrescu. Thanks for the quick response.

Do I need to add unit-tests that check the correctness of the log output?

from mixpanel-node.

If it's fairly straightforward, always helpful to have tests for the new config. Doesn't have to be extensive, just want to make sure of stuff like:

• using a customer logger doesn't throw exceptions that would break tracking
• console.log() is still getting called in the default case

from mixpanel-node.

I submitted a pull request that implements the functionality described in this ticket. I'm happy to fix problems if there are any.

from mixpanel-node.

Sorry about the delay, added a few comments, looks like it's almost ready as is.

from mixpanel-node.