"browser.close()" dosen't terminate browser process about pyppeteer HOT 7 OPEN

Same here. I just terminate them manually now.

import signal, psutil, os


def kill_child_processes(parent_pid, sig=signal.SIGTERM):
    try:
        parent = psutil.Process(parent_pid)
    except psutil.NoSuchProcess:
        return
    children = parent.children(recursive=True)
    print(children)
    for process in children:
        process.send_signal(sig)


kill_child_processes(os.getpid())

from pyppeteer.

Not correctly terminating is a "downer" for using the library at a larger scale. Having to manually kill chrome processes that are not correctly terminated is not nice. A proper mechanism should go beyond using something like await asyncio.sleep(5) and hope in the mean-time the process terminated. This 5 seconds might work on a machine that is not under heavy load.

There should be something deterministic and await browser.close() should just clean up everything with no timeout required. Otherwise this library is not usable on larger scale where you execute many operations simultaneously and therefore the PC is under heavy load already. For some reason I saw cases where also termination from python as suggested by @scythargon did not do the job. I have no idea why.

Btw. for the rest this library works fine with multiprocessing, only this "process leaks" are a bit painful and require monitoring and manual intervention.

from pyppeteer.

Not reproduced on my environment (linux) with the below code:

import asyncio
from pyppeteer import launch

async def main():
    browser = await launch(headless=False)
    await asyncio.sleep(5)
    await browser.close()   # browser closes here
    await asyncio.sleep(5)

asyncio.get_event_loop().run_until_complete(main())

Could you let me know your OS and the version of pyppeteer?
Latest pyppeteer version is 0.0.17, and its browser.close() method does not call self.disconnect().

from pyppeteer.

@csugzq
Hey, can you try this please - resp.html.session.browser.close().
I investigated it here - https://github.com/kennethreitz/requests-html/issues/165

from pyppeteer.

I can confirm I'm experiencing this behavior on OS X (10.12.6) and Python 3.6.5

from pyppeteer.

I experience the same on Arch Linux, Python 3.8.1.

from pyppeteer.

Same Ubuntu 19.10, python 3.7

from pyppeteer.