FootnoteLink removing trailing spaces about mistletoe HOT 6 CLOSED

Hi there! Thanks for the interest!

Jira renderer support was just added yesterday, and as you can probably tell by the code, it's not yet production ready. I'll cc the author @cctile to see if they have any idea what's going on, and I'll try to take a look once I free myself from work as well.

Wow, I had no idea there's no adequate Markdown to Jira converter..

from mistletoe.

Thanks for the quick turnaround! I will be as patient as I am eager for this tool =).

To elaborate: I might be picky with what an "adequate" converter is, but I was looking for something that works from the command line. An added bonus is that I might integrate this directly into my scripts that communicate with Jira's REST(-like) API. Most importantly however, I am lucky enough not to be in the business of running node.js and I really want to keep it that way.

from mistletoe.

Took a look at https://github.com/cctile/mistletoe/blob/dev/plugins/jira_renderer.py#L88
See two ways to fix this for render_footnote_link:

1. Quick and dirty where we introduce end space in template:

template = '[{inner}|{target}] '

2. Push fix on @miyuchina where the space is honored in the AST level.

@miyuchina your thoughts?

from mistletoe.

Also @huettenhain thanks for trying this out! Appreciate your feedback!

from mistletoe.

Oh okay, I just looked at it in more detail. I'll fix it on the parsing level. Regexes. Ugh.

from mistletoe.

Should be fixed in f73e3f1. Closing for now. Thanks again @huettenhain and @cctile !

from mistletoe.