Giter VIP home page Giter VIP logo

Comments (5)

miyuchina avatar miyuchina commented on May 28, 2024 1

Should be fixed! Two spaces or more make a sublist. Will include in the next release (I'm thinking some time around end of this month?)

from mistletoe.

miyuchina avatar miyuchina commented on May 28, 2024

Ah, I might have to fix it over the weekend, since my hands are a bit tied with work. And yes, the reasons you gave are correct.

Preliminary thoughts about (2): CommonMark does not allow less than 4 spaces of indent, and GitHub does not allow less than 2. I'm leaning towards following the GFM convention here, and not allowing only 1 space before sublists. There could be lazy-continuation lines that start with a space (they shouldn't do that, but one space also does not give enough visual cue that the current line is in a sublist.)

What do you think?

from mistletoe.

huettenhain avatar huettenhain commented on May 28, 2024

If you want, I can try and make a PR for this, I just always feel like you can fix stuff much quicker ;-).

Regarding 2: I completely agree that it is unnecessary to recognize single space indent for new sublists. I am somewhat biased here since I would really like 2 space indent to work, and I find it visually appealing when editing the Markdown source. However, let me also say that if you want to enforce CommonMark, that would be completely legitimate and understandable.

from mistletoe.

miyuchina avatar miyuchina commented on May 28, 2024

This is taking me longer to fix because lists are complicated to parse 😞 Will report back with hopefully more cheerful news, but I am definitely working on both requests.

Thanks for the patience!

from mistletoe.

huettenhain avatar huettenhain commented on May 28, 2024

Again, I can only stress how grateful I am for the library and your quick response to requests. Please don't worry and take your time. Thanks again!

from mistletoe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.