twitch_vod_fetch does not finish appending batched chunks about fgtk HOT 3 CLOSED

No, can totally reproduce it even more obviously with "file_append_batch = 10" left as it is and 5chunks-by2 command, where resulting file is left completely empty and all chunks in the tmp dir.
It's likely due to arbitrary order in which aria2 finished downloading chunks in parallel, while script has to append them in strict order.

Anyway, that missing check was definitely an issue and skipped appending last 0-file_append_batch chunks.
If you got lucky and download ended with "n >= file_append_batch" chunks still in tmp, it'd append them, which is why cutting short only happened in some cases, but not all of them.
Can happen due to that random downloading order ([re-]started sequentially, finish whenever), e.g. if chunk-1 out of 20 finishes last, all 20 would've been appended after that just fine.

Should be fixed now, should've looked into it earlier myself.
Thanks a lot for reporting!

from fgtk.

Ah yes, I was wondering why I was seeing videos seemingly cut a little short for a while, but never thought to check, always thinking "eh, must be twitch anyway". Will look into it in a moment.

from fgtk.

Pretty sure it was missing chunks.finished check, now fixed in 7214985, but I can't seem to reproduce the issue so far, which is weird, as it definitely should happen with that check missing, will try a bit more.

from fgtk.