Comments (8)
Why is this issue closed ? It's indeed important to upgrade to 4.4
from react-native-adyen-payment.
Yes, I just have to clean it a bit. I'll try that this evening. I also removed the dependencies to jcenter ;)
from react-native-adyen-payment.
+1
I think this upgrade is very important and becoming quiet urgent.
Android 12 is not officially supported with current version.
from react-native-adyen-payment.
I have a patch to use with patch-package, currently in testing for my company, if we are satisfied with the result, I'll push it here. It doesn't update to 4.0.0 but it adds compatibility to Android 12.
from react-native-adyen-payment.
That's great to hear, thanks @Gp2mv3 !
By any chance, would you have a link where I can see this patch, so I can try it on my side as well ?
I saw on android SDK repo that support for Android 12 has been added in 4.1.0 (https://github.com/Adyen/adyen-android/releases#4.1.0), so I wonder how you achieved it without updating the android SDK. Anycase, if your patch works that's a great news 🙂
from react-native-adyen-payment.
As promised, here is the patch file (used with patch-package):
diff --git a/node_modules/react-native-adyen-payment/android/build.gradle b/node_modules/react-native-adyen-payment/android/build.gradle
index 0ad693a..327a7ba 100644
--- a/node_modules/react-native-adyen-payment/android/build.gradle
+++ b/node_modules/react-native-adyen-payment/android/build.gradle
@@ -68,13 +68,16 @@ repositories {
url "$rootDir/../node_modules/jsc-android/dist"
}
google()
- jcenter()
+ // jcenter()
flatDir {
- dirs 'libs'
+ dirs 'libs'
}
}
dependencies {
+
+ implementation fileTree(dir: 'libs', include: ['*.jar'])
+
// ref:
// https://github.com/facebook/react-native/blob/0.61-stable/template/android/app/build.gradle#L192
//noinspection GradleDynamicVersion
diff --git a/node_modules/react-native-adyen-payment/android/src/main/AndroidManifest.xml b/node_modules/react-native-adyen-payment/android/src/main/AndroidManifest.xml
index c641dca..e2a4178 100644
--- a/node_modules/react-native-adyen-payment/android/src/main/AndroidManifest.xml
+++ b/node_modules/react-native-adyen-payment/android/src/main/AndroidManifest.xml
@@ -5,16 +5,16 @@
<activity
android:name=".ui.AdyenComponentActivity"
android:launchMode="singleTask"
- android:theme="@style/AdyenCheckout.Translucent">
+ android:theme="@style/AdyenCheckout.Translucent"
+ android:exported="false">
<intent-filter>
<action android:name="android.intent.action.VIEW" />
<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />
-
<data
- android:host="${applicationId}"
+ android:host="adyen.com.sparks"
android:scheme="${checkoutRedirectScheme}" />
</intent-filter>
</activity>
@@ -24,6 +24,8 @@
<service
android:name=".AdyenComponentService"
android:permission="android.permission.BIND_JOB_SERVICE" />
- </application>
+ <activity android:name="com.adyen.checkout.dropin.ui.DropInActivity" android:exported="true" />
+ <receiver android:name="com.adyen.threeds2.internal.AppUpgradeBroadcastReceiver" android:exported="false" />
+ </application>
</manifest>
The key is to add the android:exported flags and to remove center (which is down for some days now). You'll need to add the jars for wechat-sdk and paranoid-core in android/app/libs
as well.
from react-native-adyen-payment.
I agree that we should update the SDK (especially with all the jCenter outages recently). Sadly, I do not have much time to spend on this. But I might be able to spend some time testing the new version (in fact, that is a good excuse to finally move from my fork to using the actual repo again now that the fixes in there have been merged). I am also happy to review all the Android code changes.
FYI: @mkharibalaji Is not very active anymore in this repository (only for the occasional merge/release after some poking).
@mickadoua @Gp2mv3 and me have been the most active users in this repo over the last couple of months, I think.
from react-native-adyen-payment.
FYI: Adyen is working on their own version of this library https://github.com/Adyen/adyen-react-native
It is currently not finished enough for our usecase, but we'll keep an eye on it.
from react-native-adyen-payment.
Related Issues (20)
- [Android] 3DS2 Infinite Loading HOT 1
- iOS Example don't work
- stuck on "CVC is not the right length" HOT 1
- Adyen Error on paymentMethod
- crash on Huawei devices,
- Apple Pay HOT 9
- Cant hide showStoredPaymentMethod with BCMC on IOS HOT 2
- Apple Pay doesnt work HOT 5
- Payment has error HOT 2
- Task react-native-adyen-payment:compileDebugKotlin fails on RN 0.65.1 HOT 8
- UI for showing cardHolder name. HOT 1
- Could not find com.tencent.mm.opensdk:wechat-sdk-android-without-mta:5.1.6. HOT 7
- Android cannot link lib if MainApplication is Kotlin file
- Question: How to build AdyenPayment HOT 1
- Building Android for Expo EAS Crashing org.gradle.api.internal.artifacts.repositories.DefaultFlatDirArtifactRepository HOT 1
- React peer dependency version
- Linking failed even though I add manually to MainApplication.java HOT 1
- Question for AdyenPayment.initialize? HOT 12
- Question - Is it compatible with GraphQL api? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-adyen-payment.