Test failures with pypy3.10 7.3.13 about overrides HOT 10 CLOSED

It looks like the failure is around properly adding the __module__ attribute to callable2. How is that created?

from overrides.

Tracked in https://foss.heptapod.net/pypy/pypy/-/issues/4029

from overrides.

It seems to be int.bit_length.__module__, which does not exist in cpython, but is None in pypy. I suppose it's the usual problem with method_descriptor on CPython, which would mean this affects the methods of all builtin types. Method descriptors don't exist in pypy, instead we have regular function objects, but with __module__ set to None.

from overrides.

right, overrides would produce a similar exception on CPython if you make a slightly weird method where you del the __module__ attribute, like this:

class ASuper:
    def some_method(self):
        return 1
    del some_method.__module__
class ASub(ASuper):
    @override
    def some_method(self):
        return 2

yields:

tests/test_overrides.py:97: in <module>
    class ASub(ASuper):
tests/test_overrides.py:98: in ASub
    @override
overrides/overrides.py:143: in override
    return _overrides(method, check_signature, check_at_runtime)
overrides/overrides.py:170: in _overrides
    _validate_method(method, super_class, check_signature)
overrides/overrides.py:189: in _validate_method
    ensure_signature_is_compatible(super_method, method, is_static)
overrides/signature.py:99: in ensure_signature_is_compatible
    same_main_module = _is_same_module(sub_callable, super_callable)
overrides/signature.py:61: in _is_same_module
    mod2 = mod2.split(".")[0]
E   AttributeError: 'NoneType' object has no attribute 'split'

from overrides.

Method descriptors don't exist in pypy, instead we have regular function objects, but with __module__ set to None

Could we remove the __module__ attribute from methods on builtins?

from overrides.

So I guess the fix here is to check for None as well as AttributeError

from overrides.

yeah, pypy could try to make sure that the methods of builtins raise an error when reading __module__ instead of returning None. I can give that a try

from overrides.

that said, the __module__ attribute of builtin functions (eg abs) is "builtin" in both pypy and cpython, maybe we should simply adopt that for builtin methods too? Anyone have an opinion on either of these options?

from overrides.

I don't know whether it's worth changing this in PyPy — either way, I'll try making a PR to support both missing and None attribute, if only to support prior PyPy versions.

from overrides.

Thank you all for informing, debugging and solving the issue!

from overrides.