Comments (4)
Thanks for the report.
Use of uninitialized value $input_line_number in concatenation (.) or string at /opt/local/lib/perl5/site_perl/5.12.3/Perl/Tidy.pm line 4019.
: Syntax check deactivated for safety; you shouldn't run this as root
There are possibly two issues here, and I'm not sure that
githook-perltidy is the source of either of them:
- There is a warning being generated by Perl::Tidy, apparently during
the output of the error message. I don't know how often this occurs,
but it would be something for the Perl::Tidy developers to look at. - Perl::Tidy is not running a syntax check because the tests were run
as root, which is good advice, but I don't think I've seen it
documented anywhere. I'm not sure if that also stops the tidying part.
What happens if you run the tests as a non-root user?
Mark.
Mark Lawrence
from githook-perltidy.
hi.
You are right, running the tests as non-root passes OK. thanks.
So, should I pester Perl::Tidy's author about why it doesn't work in root?
Shmuel.
from githook-perltidy.
So, should I pester Perl::Tidy's author about why it doesn't work in
root?
I would rate the important of this issue as very low, since running
tidy-type tools as root is probably (should be!) uncommon.
However if you have the time and the energy you could create a ticket
somewhere (rt.cpan.org?) documenting the unexpected / undocumented
Perl::Tidy behaviour. At least then the author knows of the issue and
can decide on their own what effort it deserves.
Mark Lawrence
from githook-perltidy.
Well, Perl::Tidy itself installed without failing its tests, so...
from githook-perltidy.
Related Issues (10)
- data paragraphs in PODs are mangled HOT 7
- Quiet mode HOT 2
- pre-commit support HOT 3
- Is there any common way to do something like an --ignore-path option? HOT 2
- New release planned? HOT 2
- Need full path in the pre/post-commit files HOT 6
- Perl::Critic support HOT 4
- Get it to recognize .cgi files HOT 5
- could not open .git/MERGE_HEAD HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from githook-perltidy.