Giter VIP home page Giter VIP logo

Comments (5)

ieee8023 avatar ieee8023 commented on September 17, 2024

Hey, sorry for the delay, I will have a chance to look into this soon!

from torchxrayvision.

Htermotto avatar Htermotto commented on September 17, 2024

Thanks! Interested to know what you find. Curious if one of the issues is a calibration one.

from torchxrayvision.

ieee8023 avatar ieee8023 commented on September 17, 2024

Hey I had a chance to look at this. I updated the notebook so it runs and computes more metrics. One issue there was that it was applying the sigmoid after the model was already doing it as you said. I'm not sure why that was there but it wouldn't have impacted the AUC anyway and the AUC values were similar. The samples were randomly selected before so it is not possible to process the same samples again. I set the random seed this time.

The accuracy and F1 scores seem bad. Setting a threshold at 0.5 appears not optimal for this data. The "all" model was calibrated using the test splits over all the datasets so it is likely not perfect for these samples.

Screen Shot 2022-11-05 at 11 58 54 AM

from torchxrayvision.

Htermotto avatar Htermotto commented on September 17, 2024

Hi thanks for looking into this and fixing the double sigmoid bug!

I agree that the threshold of 0.5 is not optimal. In your code there are some custom thresholds set, and we tried using those, but it didn't seem to make a huge difference. However it could have been from the double sigmoid pushing the numbers up.

from torchxrayvision.

ieee8023 avatar ieee8023 commented on September 17, 2024

Let me know if this issue is not resolved. I'll close it for now.

from torchxrayvision.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.