Giter VIP home page Giter VIP logo

Comments (6)

braceletboy avatar braceletboy commented on September 25, 2024 1

Yes, I had a look. I fetched the pull request. I will make the necessary changes as a new branch and send a pull request from my side.

from benchmarks.

zoq avatar zoq commented on September 25, 2024

You are right they should behave the same, the decision tree script should work on a single dataset as well, without the prediction step. You are right about if (len(self.dataset) > 1), actually this is already fixed in my fork; will open a PR in the next days unless you like to do it?

from benchmarks.

braceletboy avatar braceletboy commented on September 25, 2024

I would love to change the benchmarking scripts so that they work on single dataset. I think there are more like that, for example knc.py. It's a comparatively easy fix and will help me get an idea of writing benchmarking scripts. Thanks alot!

And about the if (len(self.dataset) > 1), I think I will leave it to you if you have already fixed it.

from benchmarks.

zoq avatar zoq commented on September 25, 2024

If you like to take a look at this, it probably makes sense to take a look at the update I'm working on. I'll try to open a PR either today or tomorrow.

from benchmarks.

braceletboy avatar braceletboy commented on September 25, 2024

Okay sure. Thanks alot!

from benchmarks.

zoq avatar zoq commented on September 25, 2024

@braceletboy I've opened #137 let me know what you think.

from benchmarks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.