Comments (6)
As for differences between EEG vs MEG, won't they be ironed out before the extensions are merged into the main spec?
However, there will probably always be slight differences, such as different coordinates.json
files between MEG, EEG, and iEEG. --> a "kind" argument would allow us to handle these very easily and explicitly.
from mne-bids.
Could we not infer it directly from the info
object?
from mne-bids.
we use it internally to make sure we are pulling modality-specific channels and info. I think inferring would be problematic with files with combined eeg
and meg
. also, there are some differences in the json writing for meg versus eeg so I think it would be better to remain explicit
from mne-bids.
If I remember correctly, the kind
argument was introduced by @choldgraf to deal with the fact that the iEEG validator was not yet merged into the main BIDS validator. It allows us to keep the check against the MEG validator in the tests while giving users the option to try the experimental iEEG conversion of MNE-BIDS. Once the iEEG validator is merged, we should remove the kind
argument so that both the MEG as well as the iEEG conversion is tested.
As for differences between EEG vs MEG, won't they be ironed out before the extensions are merged into the main spec? Basically I feel the only spec we should respect is the main spec. The extensions are just temporary ...
from mne-bids.
as well as we are able to swap among the metadata files appropriately and it works seamless, i would be OK with the kind argument going away. we would need to decide before release otherwise we will be breaking api 🙃
from mne-bids.
@teonbrooks let's close this issue as it's a duplicate of #73 and #105 ?
from mne-bids.
Related Issues (20)
- No RuntimeWarning in the BIDSPath example although it is mentioned in the text HOT 2
- read_raw_bids can't create events if taskname includes decimal dot HOT 2
- BUG: Error when writing calibration for empty-room file HOT 2
- FutureWarning: with copy=False --> set default explicity HOT 5
- Q: Release? HOT 2
- Add copyright holder to each file, and remove individual authors HOT 2
- add circleci config.yml to gh-pages branch?
- MAINT: update release protocol --> versioning scheme HOT 4
- MAINT: MNE-Python now uses edfio instead of EDFlib-Python
- adjust pip install
- After switch to hatchling&hatch-vcs: heading in documentation is taking up too much space HOT 4
- How to silence warnings in mne_bids.write_raw_bids() HOT 3
- BIDS anonymize dataset unwanted behavior for split. HOT 4
- prepare for pytest>=8 HOT 1
- allow BIDSPath(check=False) to work for _check_key_val() HOT 3
- `read_raw_bids()` tries to process task name without checking if a task exists HOT 5
- InvalidDistribution: Metadata is missing required fields: Name, Version. HOT 5
- MAINT: remove ref-names from git_archive.txt? HOT 1
- Request for New Version Release on pip HOT 14
- issue with CI and inspect module HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mne-bids.