Giter VIP home page Giter VIP logo

Comments (6)

sappelhoff avatar sappelhoff commented on August 16, 2024 1

As for differences between EEG vs MEG, won't they be ironed out before the extensions are merged into the main spec?

However, there will probably always be slight differences, such as different coordinates.json files between MEG, EEG, and iEEG. --> a "kind" argument would allow us to handle these very easily and explicitly.

from mne-bids.

jasmainak avatar jasmainak commented on August 16, 2024

Could we not infer it directly from the info object?

from mne-bids.

teonbrooks avatar teonbrooks commented on August 16, 2024

we use it internally to make sure we are pulling modality-specific channels and info. I think inferring would be problematic with files with combined eegand meg. also, there are some differences in the json writing for meg versus eeg so I think it would be better to remain explicit

from mne-bids.

jasmainak avatar jasmainak commented on August 16, 2024

If I remember correctly, the kind argument was introduced by @choldgraf to deal with the fact that the iEEG validator was not yet merged into the main BIDS validator. It allows us to keep the check against the MEG validator in the tests while giving users the option to try the experimental iEEG conversion of MNE-BIDS. Once the iEEG validator is merged, we should remove the kind argument so that both the MEG as well as the iEEG conversion is tested.

As for differences between EEG vs MEG, won't they be ironed out before the extensions are merged into the main spec? Basically I feel the only spec we should respect is the main spec. The extensions are just temporary ...

from mne-bids.

teonbrooks avatar teonbrooks commented on August 16, 2024

as well as we are able to swap among the metadata files appropriately and it works seamless, i would be OK with the kind argument going away. we would need to decide before release otherwise we will be breaking api 🙃

from mne-bids.

jasmainak avatar jasmainak commented on August 16, 2024

@teonbrooks let's close this issue as it's a duplicate of #73 and #105 ?

from mne-bids.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.