Bug, specific allias crash the app about maid HOT 7 CLOSED

so do you mean you're setting user alias to <|im_start|> and you're also enabling the chatml toggle? the user alias effectively does the same thing as the chatml toggle exact you can specify a custom prefix so if you're enabling chatml and adding in the chatml prefix as the user alias what its probably doing would look like this:

<|im_start|><|im_start|>user prompt<|im_start|><|im_start|>assistant prompt?

from maid.

so do you mean you're setting user alias to <|im_start|> and you're also enabling the chatml toggle? the user alias effectively does the same thing as the chatml toggle exact you can specify a custom prefix so if you're enabling chatml and adding in the chatml prefix as the user alias what its probably doing would look like this:

<|im_start|><|im_start|>user prompt<|im_start|><|im_start|>assistant prompt?

This bug is older than the toggle and it happens independently of the State of the toggle. You are right if the toggle works as intended, it would make it double which is bad, thanks for clarifying that. But the question is why is the crash happening? Maybe it's the length of the string for the aliases together that's limited some how?

from maid.

And a follow up question, if the chatml toggle is working as intended, why isn't that crashing the app?

from maid.

so do you mean you're setting user alias to <|im_start|> and you're also enabling the chatml toggle? the user alias effectively does the same thing as the chatml toggle exact you can specify a custom prefix so if you're enabling chatml and adding in the chatml prefix as the user alias what its probably doing would look like this:
<|im_start|><|im_start|>user prompt<|im_start|><|im_start|>assistant prompt?

This bug is older than the toggle and it happens independently of the State of the toggle. You are right if the toggle works as intended, it would make it double which is bad, thanks for clarifying that. But the question is why is the crash happening? Maybe it's the length of the string for the aliases together that's limited some how?

It could be related to #210, the core of that issue is a buffer overflow is occurring when i try to inject the context. Perhaps its causing a similar issue

from maid.

And a follow up question, if the chatml toggle is working as intended, why isn't that crashing the app?

I havnt tested the chatml so im not sure if it does work.

from maid.

so do you mean you're setting user alias to <|im_start|> and you're also enabling the chatml toggle? the user alias effectively does the same thing as the chatml toggle exact you can specify a custom prefix so if you're enabling chatml and adding in the chatml prefix as the user alias what its probably doing would look like this:
<|im_start|><|im_start|>user prompt<|im_start|><|im_start|>assistant prompt?

This bug is older than the toggle and it happens independently of the State of the toggle. You are right if the toggle works as intended, it would make it double which is bad, thanks for clarifying that. But the question is why is the crash happening? Maybe it's the length of the string for the aliases together that's limited some how?

It could be related to #210, the core of that issue is a buffer overflow is occurring when i try to inject the context. Perhaps its causing a similar issue

Hmm, I see. The thing is I can have very long preprompts, and they don't crash the app. So it seems to have to do with either the substring "<|im_start|>" itself or the way aliases are handled. Because otherwise my long preprompt should be the factor that crashes the app but it doesn't (and even with an empty preprompt, double <|im_start|> leads to crash).

from maid.

This issue is possibly also fixed now

from maid.