OY labels in plot.mobr() function from branch 4cur about mobr HOT 8 CLOSED

Hi Valentin,

Hmm good point about keeping the labels consistent. Does "delta of the
deltas" make (more) sense to you? I made the change to plot.mobr() because
it was proven to be a somewhat confusing concept in our discussions. The
values are indeed difference between the differences (which is where the
delta-of-delta came from) but they can also be interpreted as the unique
effect of each factor on S. Let me open an issue for now and see what other
folks think.

Thanks,
Xiao

On Tue, Oct 11, 2016 at 5:47 AM, Valentin S [email protected]
wrote:

Hi @rueuntal https://github.com/rueuntal !

I saw that some minor changes took place in the OY label names inside the
plot.mobr() function.
Line 98 in mobr.R is now

ylabs = rep('delta-S', 3)

And previously it was

ylabs = c('delta-S', rep('delta-delta-S', 2))

Shouldn't the old line of code be kept? Otherwise is also not consistent
with the output from plot_9_panels() function. But I'm not familiar with
the entire concept so, please correct me if I'm wrong.

Best,
Valentin

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#82, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABGoPqhm4LCPtxLPowePNsIyZhQE8TOiks5qy1sigaJpZM4KTcY_
.

from mobr.

Oops what was I thinking... it's already an issue :)

from mobr.

@valentinitnelav and @rueuntal I think the old labels were better. Let's keep brainstorming if there is a simpler way to refer to the delta of the delta S values.

from mobr.

I'll add this to a pull request I'll submit in the next few days.

from mobr.

Thanks Dan - I'd have no objection to reverting it back if it doesn't prove to be a hurdle for users.

from mobr.

Sounds good. I'm working tonight trying to smooth out some of the edges on
the package and make it so that it can be loaded with the function
'library' fingers crossed!

On Sun, Nov 20, 2016 at 9:28 PM, Xiao Xiao [email protected] wrote:

Thanks Dan - I'd have no objection to reverting it back if it doesn't
prove to be a hurdle for users.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#82 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABIp7QnNyPzqD_t6xgqhhg0PQyv9Qvxbks5rAQHngaJpZM4KTcY_
.

Daniel J. McGlinn, PhD
Assistant Professor
College of Charleston
Department of Biology
Harbor Walk West, rm 203
360 Concord Street
Charleston, SC 29401
http://mcglinn.web.unc.edu/
office: 843-953-0190
cell: 405-612-1780

from mobr.

Great!

On Sun, Nov 20, 2016 at 9:29 PM, Dan McGlinn [email protected]
wrote:

Sounds good. I'm working tonight trying to smooth out some of the edges on
the package and make it so that it can be loaded with the function
'library' fingers crossed!

On Sun, Nov 20, 2016 at 9:28 PM, Xiao Xiao [email protected]
wrote:

Thanks Dan - I'd have no objection to reverting it back if it doesn't
prove to be a hurdle for users.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#82 (comment), or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABIp7QnNyPzqD_
t6xgqhhg0PQyv9Qvxbks5rAQHngaJpZM4KTcY_>
.

Daniel J. McGlinn, PhD
Assistant Professor
College of Charleston
Department of Biology
Harbor Walk West, rm 203
360 Concord Street
Charleston, SC 29401
http://mcglinn.web.unc.edu/
office: 843-953-0190
cell: 405-612-1780

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#82 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABGoPnMrqrfNIVD02S12zsS380ysZcflks5rAQImgaJpZM4KTcY_
.

from mobr.

Assuming we are all happy with the current axis name ("Change in S due to sth") I'll go ahead and close this. But if anyone is not happy feel free to reopen.

from mobr.