Windows RunCPM folder can't be on Dropbox about runcpm HOT 5 CLOSED

I've since tried this fix and it seems to work.

from runcpm.

This one:

int _sys_select(uint8 *disk) {
return((uint8)GetFileAttributes((LPCSTR)disk) & 0x10);
}

Should work too, right? Can you give it a try?
I am travelling and won't be able to touch RunCPM (unless on Windows) for weeks.

Thanks!

from runcpm.

Tried it here ... seems to work fine.
I will upload shortly. Thanks a lot!

from runcpm.

Since _sys_select() is always called in a boolean context, yes that should work the same.

However, with a bit more testing (and more careful reading of the WIN32API docs) I see it's not correct in the failure case. We need something like this:

int _sys_select(uint8 *disk) {
    uint32 attr = GetFileAttributes((LPCSTR)disk));
    return(attr != INVALID_FILE_ATTRIBUTES && (attr & FILE_ATTRIBUTE_DIRECTORY) != 0);
}

I've compiled and tested it (briefly), and it now works in both failure and success cases.

from runcpm.

Cool ... I have pushed the change regardless as it looks fine (apart from the extra parentheses on the second line ... :)
I will test more when I get back from my trip.

from runcpm.