css styles about modeldown HOT 4 CLOSED

@pbiecek I suppose we'd like to have footer normal (white background, not fixed position) - so just removing "footer" class ?

Also, should we give an option to selected the theme in call to modelDown ? If so which one should be default ? Or if we're not giving user an option to select theme then which one should we use - theme_mi2 or theme_drwhy ?

from modeldown.

@Matiszak yes, it would be better to remove 'fixed position', IMHO violet will be better than white/grey

For themes, I would stay with the default theme_drwhy, no need for passing this argument
the grey theme_mi2 will not suite current css anyway

from modeldown.

@pbiecek I put PR for violet footer, it looks quiete nice. Although when I tried to use theme_drwhy I noticed it is not in the latest DALEX release 0.2.7. When can we expect it to be relased so that we can use it ? Or we can just copy the theme definition into this package so that we can later style the plots independently. But the best option I think would be to use theme_drwhy and when needed override the theme.

from modeldown.

Thanks, it looks very good.
DALEX 0.2.8 is on GitHub. And I am testing modelDown with this dev release.
Due to the CRAN policy I cannot upload DALEX 0.2.8 to CRAN before March 19. I will do this just after this date.

from modeldown.