Comments (4)
ThomasWaldmann
commented on June 2, 2024
Original comment by Thomas Waldmann (Bitbucket: thomaswaldmann, GitHub: thomaswaldmann).
the name_validator already disqualifies names ending with a slash.
the validation is not strict yet (but just warns), but there is another issue open for this.
from moin.
ThomasWaldmann
commented on June 2, 2024
Original comment by Thomas Waldmann (Bitbucket: thomaswaldmann, GitHub: thomaswaldmann).
partly fixed by: http://hg.moinmo.in/moin/2.0/rev/f38a893334b5
(that changeset at least makes it hard to visit or create such items from the wiki UI)
we still want that validation code mentioned above, for other ways of creating items.
from moin.
ThomasWaldmann
commented on June 2, 2024
Original comment by xiaq (Bitbucket: xiaq, GitHub: xiaq).
Besides being confusing to have both Example and Example/, it also confuses the index code, which uses on '/' in relname to decide whether an item is a direct subitem or not.
Try creating test.moinmo.in/Home/lorem/ and see what appears on the subitem sidebar of test.moinmo.in/Home.
from moin.
ThomasWaldmann
commented on June 2, 2024
Original comment by Thomas Waldmann (Bitbucket: thomaswaldmann, GitHub: thomaswaldmann).
note: this should be part of input data validation and we should just reject creating items with names ending with a slash.
from moin.
Related Issues (20)
- Traceback when trying to login with a user migrated from moin1.9
- Traceback when adding a subscription with nameprefix and ending slash HOT 1
- readthedocs does not provide access to /docs/examples/* HOT 1
- traceback when modifying item with Basic Theme
- Missing macros
- Github actions warnings about deprecated Node.js
- Setting a global default markup HOT 4
- import19 lacks support for UserGroup and WikiDict conversion
- add list of forbidden_user_names to constants/misc.py HOT 5
- import19 cannot import a moin1.9 wiki farm HOT 2
- Double click on meta pages with rendered content (rename, delete) of item load modify page HOT 1
- ItemList macro fails when used inline HOT 1
- wikiconfig.py documentation and example HOT 6
- update docs change log for moin2 beta release HOT 5
- drop direct calls to setup.py
- get rid of linux packaging files
- quickinstall.py and "m" need to die HOT 3
- increase pypi.org bus factor HOT 1
- increase readthedocs.org bus factor: add maintainers
- Failing tests on Windows cannot be reproduced
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from moin.