Giter VIP home page Giter VIP logo

Comments (6)

gnodet avatar gnodet commented on May 28, 2024

@olamy, would you mind having a look at this PR if you have a few minutes ?

from exec-maven-plugin.

olamy avatar olamy commented on May 28, 2024

@gnodet LGTM please do a real pr. ATM it's only a change in your fork :-)

from exec-maven-plugin.

gnodet avatar gnodet commented on May 28, 2024

@olamy The related PR is #72

from exec-maven-plugin.

khmarbaise avatar khmarbaise commented on May 28, 2024

It would be great having an unit or integration test for this?

from exec-maven-plugin.

gnodet avatar gnodet commented on May 28, 2024

Fair enough, I'll have a look.

from exec-maven-plugin.

gnodet avatar gnodet commented on May 28, 2024

I wrote an integration test, but unfortunately, I don't see a good way to make it work.
The reason is that the way I thought about testing that is to run the tty unix command which returns the name of the terminal device. If the inheritIo flag works, it should be an existing terminal, else the command returns not a tty. The problem is that this can only work if the maven process actually has a terminal correctly set up (that's the exact problem I'm trying to solve for the exec'ed process here). So in order for that to work, it would require the maven-invoker-plugin to also be able to inherit the terminal. Furthermore, this would also only work if running from a real terminal, so that automated testing in jenkins or such may not work.

from exec-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.