Comments (5)
The TypeError has been fixed. This is a planned feature, though. (Supporting the conversion of ordinal strings). At the moment the string third tuesday this december
will ignore the third
and instead be parsed as tuesday this september
. I'll leave this issue open and mark it as a feature
from chronic.
Outstanding, thanks for the update. I'll keep using the original syntax for now.
from chronic.
I've taken a quick shot at this, and although it's extremely easy to implement, there's the issue of parsing second
as an ordinal when Chronic relies on it being a literal second
. With this patch We can work with the following output:
>> Chronic::Numerizer.numerize 'thirty first month on day one'
=> "31st month on day 1"
>> Chronic::Numerizer.numerize 'twenty second day month twelve'
=> "22nd day month 12"
If anyone has any thoughts for dealing with seconds, feel free to discuss it here
from chronic.
So I guess parsing 'second' can be a special case, and unless it's suffixed with 'day/month/hour/minute/second' then people probably mean a literal second. I've updated the patch to allow for this. Thoughts? @mojombo?
from chronic.
Yeah, I'd let context rule the day and treat 'second' in a special way.
from chronic.
Related Issues (20)
- Bug/Exception: NoMethodError: undefined method `begin' for nil:NilClass HOT 1
- Incorrect `last monday` HOT 1
- Parsing "next january" throws runtime error
- Common format like 'Thursday 07 March 2019' is not supporting, which is even supported by DateTime
- Chronic can't parse year "00": returns nil HOT 3
- Chronic parsing "today at noon" as tomorrow midnight - daylight saving related
- [QUESTION] Where I can find the CI service?
- incorrect parsing when introduce time HOT 3
- [Gem bug only] Parser handles missing years differently with numbers vs month names HOT 1
- what is qs in -s, --start <date:qs> HOT 1
- Chronic not selecting correct 1st monday of the month
- Chronic thinks it can parse a date if the string begins "a " HOT 2
- Returning incorrect time HOT 1
- Un-parseable date HOT 3
- Chronic doesn't take into consideration 1st date of the month when computing `nth day this month` HOT 1
- Can't set time_class to Date HOT 1
- New stable release? HOT 1
- Chronic.parse "1 year, 7 months ago" breaks HOT 2
- yyyy-mm-dd with day name HOT 1
- Parsing Feb15'24 is incorrect, Feb15'24 doesn'T work at all
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chronic.