Giter VIP home page Giter VIP logo

Comments (5)

leejarvis avatar leejarvis commented on August 24, 2024

The TypeError has been fixed. This is a planned feature, though. (Supporting the conversion of ordinal strings). At the moment the string third tuesday this december will ignore the third and instead be parsed as tuesday this september. I'll leave this issue open and mark it as a feature

from chronic.

cmhobbs avatar cmhobbs commented on August 24, 2024

Outstanding, thanks for the update. I'll keep using the original syntax for now.

from chronic.

leejarvis avatar leejarvis commented on August 24, 2024

I've taken a quick shot at this, and although it's extremely easy to implement, there's the issue of parsing second as an ordinal when Chronic relies on it being a literal second. With this patch We can work with the following output:

>> Chronic::Numerizer.numerize 'thirty first month on day one'
=> "31st month on day 1"
>> Chronic::Numerizer.numerize 'twenty second day month twelve'
=> "22nd day month 12"

If anyone has any thoughts for dealing with seconds, feel free to discuss it here

from chronic.

leejarvis avatar leejarvis commented on August 24, 2024

So I guess parsing 'second' can be a special case, and unless it's suffixed with 'day/month/hour/minute/second' then people probably mean a literal second. I've updated the patch to allow for this. Thoughts? @mojombo?

from chronic.

mojombo avatar mojombo commented on August 24, 2024

Yeah, I'd let context rule the day and treat 'second' in a special way.

from chronic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.