Giter VIP home page Giter VIP logo

Comments (8)

nicholsn avatar nicholsn commented on July 21, 2024

@bpinsard, you might want to take a look at our fork of dcmstack at https://github.com/IBIC/dcmstack that has some support for Philips Enhanced DICOM. Hoping to get these changes incorporated into the main branch of dcmstack soon.

from dcmstack.

moloney avatar moloney commented on July 21, 2024

I haven't seen this before. Could you send me the JSON? For example you could do "nitool dump myfile.nii.gz > myjson.txt".

from dcmstack.

bpinsard avatar bpinsard commented on July 21, 2024

I had tried the guess-dim branch directly on the enhanced data but the same thing happens.
here are the lines I extracted that make json library crash at loading:

            "DimensionIndexSequence": [
                {
                    "DimensionOrganizationUID": "2.16.124.113543.6006.99.02479373120167955565", 
                    "DimensionIndexPointer": (0020, 9056), 
                    "FunctionalGroupPointer": (0020, 9111)
                }, 
                {
                    "DimensionOrganizationUID": "2.16.124.113543.6006.99.02479373120167955565", 
                    "DimensionIndexPointer": (0020, 9057), 
                    "FunctionalGroupPointer": (0020, 9111)
                }
            ], 

maybe these self referential dicom tags code are the problem?

from dcmstack.

moloney avatar moloney commented on July 21, 2024

It looks like those tags are not being serialized correctly. What is the VR of those elements?

from dcmstack.

bpinsard avatar bpinsard commented on July 21, 2024

the VR is AT

from dcmstack.

moloney avatar moloney commented on July 21, 2024

Could you test the referenced branch, I think it should fix the issue. You will need to reconvert the files.

from dcmstack.

bpinsard avatar bpinsard commented on July 21, 2024

it works, thanks, maybe these tags should be filtered out as they do refers to dicoms ?

from dcmstack.

moloney avatar moloney commented on July 21, 2024

OK, merged it into master.

Currently, the default filtering is just intended to remove PHI. It should however be easy enough to filter any tag with a given VR if a user wants that.

from dcmstack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.