Giter VIP home page Giter VIP logo

Comments (7)

a-r-j avatar a-r-j commented on May 25, 2024 1

Hi @NatureGeorge you can now (0.0.6+) select multiple files to open in the same viewer. You can also open the contents of folder in a single viewer. It's not quite the same as adding to a viewer but I think it's close enough to consider this closed :)

from vscoding-sequence.

a-r-j avatar a-r-j commented on May 25, 2024

Hi @jmeier-absci thanks for the request! I completely agree & I'm working on it. This is my first shot at writing an extension so bear with me 😅

from vscoding-sequence.

a-r-j avatar a-r-j commented on May 25, 2024

Hi @jmeier-absci think I've figured it out. Update should be live on the extension marketplace. Mind giving it a test drive & confirming it works as expected?

from vscoding-sequence.

NatureGeorge avatar NatureGeorge commented on May 25, 2024

Hi! Appreciate your work. But the Right-click open seems only support .pdb suffix for now. It should be straightforward to add other suffixes like .pdb.gz, .cif, .cif.gz etc.
Besides, I notice that every single Right-click open behavior would start a whole new window for Protein Viewer. Maybe sometimes people would like to open multiple files in the same Protein Viewer window.

UPDATE: I also encounter a critical issue that switching between windows would result in auto-refresh.

from vscoding-sequence.

a-r-j avatar a-r-j commented on May 25, 2024

Hi @NatureGeorge thanks for this!

Wrt supporting additional file extensions, that should be straightforward and I can most likely take care of it today.

For opening multiple files, I'll have to think about the best way to handle it. My first thought is to support opening multiple files at once - I'm not quite sure how I'd go about adding a new file to an existing viewer through VSCode.

For the switching issue, I can check that out too. I'm not 100% sure on how to handle it - if it's poor execution on my part or the way that VSCode deals with background web panels (to save resources or something). If you have some familiarity, it'd be great if you could share 😁

from vscoding-sequence.

a-r-j avatar a-r-j commented on May 25, 2024

Hey @NatureGeorge

I've made the changes to support additional filetypes:

.pdb
.pdbqt
.mmcif
.gro
.xyz
.cif
.mol
.mol2
.sdf

I also believe I fixed the issue with the viewer resetting when switching panels.

I haven't quite figured out how to add files to an existing viewer - there is functionality in VSCode to update the HTML of the panel, but I believe it would force a reset of the viewer, so any customisation done before loading the second structure would be lost.

from vscoding-sequence.

NatureGeorge avatar NatureGeorge commented on May 25, 2024

Wow. Thanks for your quick reply and update! @a-r-j
I believe that adding files to an existing viewer via VS Code is quite difficult and may not be a crucial feature (since users can load other structures through Mol*'s Open Files button).

from vscoding-sequence.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.