get_transfers refuses to work with or without parameters about monerophp HOT 10 CLOSED

@serhack could you reopen this issue? I'm on it.

from monerophp.

I am opening a pull request now to add this functionality. Perhaps it was in a previous version of monero-wallet-rpc -- if you need it, it should become functional soon

from monerophp.

OK, I debugged this and solved it in #61. Thank you for your submission and I apologize for the issue! get_transfers works when feeding in an array of parameters, but when feeding in a single string as a parameter would use the nonexistent $input_type variable, whereas only $input_types exists.

Thank you, @Codivorous!

from monerophp.

PS, the docs do say the following:

   * Look up transfers
   *
   * @param  array   $input_types      Array of transfer type strings; possible values include 'all', in', 'out', 'pending', 'failed', and 'pool'  (optional)

Check the code if you have an issue, but this really should have worked with just a string as an input--I just fucked up that bit of code :) Thank you again and please let me know if you have any other issues

from monerophp.

Thanks for the quick work @sneurlax!

from monerophp.

Unfortunately, this did not fix the issue completely. While the function now doesn't crash, I still can't actually get it to work.

This is the wallet that I am serving. As you can see, it has plenty of transfers:

The RPC wallet is running, and (hopefully) working:

This is the entire code snippet I am trying to run:

And then I get this output:

Running it without any parameters doesn't do anything either:

Same output. I hope I provided enough information for you to understand my issue :p

from monerophp.

@Codivorous, could you try passing get_transfers(['in']) and/or get_transfers('in')? all isn't a thing (I am making it so now.)

from monerophp.

I can tell it's not a thing from on_get_transfers in https://github.com/monero-project/monero/blob/master/src/wallet/wallet_rpc_server.cpp ...

from monerophp.

It does indeed work when you specify "in" - so the issue here is that "all" doesn't exist, even though it's the default and is also specified in the documentation. Thank you for your help again @sneurlax!

from monerophp.

Merged, all should work now

from monerophp.