simplewallet refresh should include optional height param about monero HOT 9 CLOSED

simplewallet (by default) syncs up from the "creation date" that is serialised and stored in the .keys file

This option should disregard the date and sync from the block height

from monero.

My solution sends start_height parameter in the RPC call and only receives blocks newer than that block.
jakoblind@e4273f2

from monero.

Awesome - up for testing:) When you get a moment, can you add the start_height optional parameter to the simplewallet "refresh" CLI command as well? Good job!!

from monero.

i already added it to the refresh command. just try:
refresh 153000

if the number cant be parsed it just treats it as 0.

from monero.

Oh brilliant, I don't know how I missed that in glossing through the code!

from monero.

Right now I'm thinking about this: "This should also be the default behaviour when generating a new wallet."

After a new wallet is generated, it is not automatically synced but the user have to write "refresh" command manually. Should we instead do autosync after wallet creation?

from monero.

@jakoblind I'd say no - reason being that simplewallet is also used for offline wallet creation, so you don't want it trying to sync when the daemon may not even be accessible. Those who will use simplewallet in the long run and not touch any of the forthcoming GUI tools will be intelligent enough to refresh after create (one hopes;)

from monero.

Tested and working - can you wrap this into a PR so we can merge? Thank you!

from monero.

Merged, thank you @jakoblind!

from monero.