Write to pipe log using vmsplice() (Trac #3) about monkey HOT 3 CLOSED

Trac update at 20100726T17:59:53: charlie_brown commented:

I was skimming through the code and it came to my attention the following commented snippet:

        /* for some reason, vmsplice is not working as expected for us, 
         * maybe we need to fix something here, at the moment
         * we will keep using writev to push the iovec struct to the pipe
         *
         *
         * n = vmsplice(fd, 
         *            (const struct iovec *) mk_io->io, 
         *            mk_io->iov_idx, 
         *            SPLICE_F_GIFT);
         * return n;
         */

1. vmsplice's man page states that when the SPLICE_F_GIFT flag is present, the memory pointed by each iovec's iov_base MUST be aligned to page boundary:
   ''"Data must also be properly page aligned, both in memory and length."''
   which, if one dumps the iov_base addresses at run-time, they're not.

2. BUT if we remove SPLICE_F_GIFT, the logger writes to the files with interleaved garbage from the response headers; I haven't checked why.

from monkey.

Trac update at 20110227T00:07:34:

• edsiper changed milestone from "" to "Future Release"
• edsiper changed priority from "major" to "minor"

from monkey.

Trac update at 20110906T19:05:21:

• davidlohr commented:

This code has been determined to be unapplicable and has already been removed.

• davidlohr changed resolution from "" to "wontfix"
• davidlohr changed status from "new" to "closed"

from monkey.