Giter VIP home page Giter VIP logo

Comments (6)

blablack avatar blablack commented on May 13, 2024

I forked the code in my github account:
https://github.com/blablack/giada

I'll create a branch for this functionality - this should be easy enough to have a look at.

from giada.

blablack avatar blablack commented on May 13, 2024

After further investigation, the issue is due to the fact that the Launchpad S doesn't have a Note Off.
Every press and release of a pad are a Note On with velocity at 0 or 127.

from giada.

 avatar commented on May 13, 2024

Hi, actually we dealt with several other devices with velocity=0 as Note Off. Unfortunately, at the moment we skip the velocity byte during the MIDI learn step. We could enable a further check for those devices and map velocity=0 to a key_release event.

from giada.

blablack avatar blablack commented on May 13, 2024

Hi, I posted a fix yesterday in my fork https://github.com/blablack/giada/tree/midi_toggle

In a nutshell, I grab the note as usual during the MIDI learn step. I added a setting in the midi configuration that says the device does not send Note Off.
If that setting is activated, Giada simply ignore Note On with Velocity 0.

If you could check the code and tell me if it's acceptable - I created a git pull request as well.

from giada.

blablack avatar blablack commented on May 13, 2024

Ok, I implemented it this way now:

  • There is a general setting to set if the devices sends NoteOff or not
  • If it does then it's business as usual
  • If it doesn't, Midi learn step includes the velocity byte

Everything else works the same.

I tested it with the Launchpad, works like a charm :)

The pull request is there: #38

from giada.

 avatar commented on May 13, 2024

Feature merged into master branch. I can confirm it works like a charm :) Thanks!

from giada.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.