Giter VIP home page Giter VIP logo

Comments (9)

jodal avatar jodal commented on May 24, 2024

If the changes discussed in http://bugs.python.org/issue8713 had been available, it would solve this issue.

We use multiprocessing.Process to create subprocesses, which are done with fork() on Linux. If we could have forced multiprocessing to use exec(), then gstreamer would have access to CoreFoundation.

from mopidy.

jodal avatar jodal commented on May 24, 2024

I'm planning on moving GStreamerProcess into a thread in the main process to solve this issue.

from mopidy.

jodal avatar jodal commented on May 24, 2024

Work on this issue is to be found in the feature/threads-not-processes branch.

Current state of the branch:

  • Everything runs in threads in a single process. Threads subclasses multiprocessing.dummy.Process instead of threading.Thread, as this makes multiprocessing.Queue use automatically "safe".
  • The GStreamer + CoreFoundation problems on OS X is gone.
  • New GStreamer problems has arisen (i.e. pipeline problems), but this is probably mostly related to the GStreamer installation on the machine.
  • Old segfaults when e.g. doing libspotify searches are back.

In other words this is far from done and will be merged in 0.1.1 or more probably 0.2.0.

from mopidy.

jodal avatar jodal commented on May 24, 2024

The feature/threads-not-process branch has been merged into develop as of rev 71014be.

There are no know regressions on Ubuntu due to the merging of this branch.

The two last items in the previous comment are still valid for OS X. In other words, GStreamer pipeline errors and segfaults at libspotify search are still present at OS X, but the CoreFoundation issue has been resolved.

from mopidy.

jodal avatar jodal commented on May 24, 2024

The segfaults when doing libspotify searches are fixed by the pyspotify patch in http://github.com/winjer/pyspotify/issues/#issue/1 in combination with 4284366.

from mopidy.

jodal avatar jodal commented on May 24, 2024

The only remaining issue here is the GStreamer problems:

jodal@iota:~/dev/mopidy:develop$ GST_DEBUG_NO_COLOR=1 GST_DEBUG=2 python mopidy
INFO     -- Starting Mopidy --
** Message: pygobject_register_sinkfunc is deprecated (GstObject)
INFO     Mopidy uses SPOTIFY(R) CORE
INFO     MPD server running at [::]:6600
INFO     Connected to Last.fm
INFO     Connected to Spotify
INFO     MPD client connection from [::ffff:10.37.3.10]:57006
INFO     MPD client connection from [::ffff:10.37.3.10]:57007
INFO     MPD client connection from [::ffff:10.37.3.10]:57008
INFO     MPD client connection from [::ffff:10.37.3.10]:57009
INFO     MPD client connection from [::ffff:10.37.3.10]:57010
INFO     MPD client connection from [::ffff:10.37.3.10]:57011
INFO     MPD client connection from [::ffff:10.37.3.10]:57012
0:00:14.401201000  3288    0x104209980 WARN           basetransform gstbasetransform.c:2073:gst_base_transform_handle_buffer:<convert> error: not negotiated
0:00:14.401236000  3288    0x104209980 WARN           basetransform gstbasetransform.c:2073:gst_base_transform_handle_buffer:<convert> error: not negotiated
0:00:14.401293000  3288    0x104209980 WARN                 basesrc gstbasesrc.c:2550:gst_base_src_loop:<src> error: Internal data flow error.
0:00:14.401304000  3288    0x104209980 WARN                 basesrc gstbasesrc.c:2550:gst_base_src_loop:<src> error: streaming task paused, reason not-negotiated (-4)
ERROR    Element doesn't implement handling of this stream. Please file a bug. gstbasetransform.c(2073): gst_base_transform_handle_buffer (): /GstPipeline:pipeline0/GstAudioConvert:convert:
not negotiated

Accidently, this is the exact same error as we see on Ubuntu 10.10 in issue #24. Thus, fixing this will fix Mopidy support on both Ubuntu 10.10 and OS X.

from mopidy.

jodal avatar jodal commented on May 24, 2024

After the fix for #24 was applied, Mopidy on OS X gets a step further and fails on this when trying to play a track:

jodal@iota:~/dev/mopidy:develop$ GST_DEBUG_NO_COLOR=1 GST_DEBUG=2 python mopidy
INFO     -- Starting Mopidy --
** Message: pygobject_register_sinkfunc is deprecated (GstObject)
INFO     Mopidy uses SPOTIFY(R) CORE
INFO     Connected to Last.fm
INFO     MPD server running at [::]:6600
INFO     Connected to Spotify
INFO     MPD client connection from [::ffff:10.37.3.10]:48601
0:00:52.278484000 15391    0x104737370 WARN           basetransform gstbasetransform.c:1065:gst_base_transform_acceptcaps_default:<volume> transform could not transform 0x10098a240 in anything we support
Segmentation fault

from mopidy.

jodal avatar jodal commented on May 24, 2024

I'm marking this bug as resolved in the develop branch, as the original issue has been solved. I'll open a new bug report for the current issue blocking OS X support.

from mopidy.

jodal avatar jodal commented on May 24, 2024

This is fixed in 0.2.0. Closing.

from mopidy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.