Giter VIP home page Giter VIP logo

Comments (13)

MordechaiHadad avatar MordechaiHadad commented on June 2, 2024 1

@Ciel-MC Pretty late (I worked on this when you opened the issue but the solution originally was too complex) but the request is fulfilled.

from bob.

MordechaiHadad avatar MordechaiHadad commented on June 2, 2024

Don't think I am following what you are trying to do, bob deals with 2 types of neovim files, binaries (nightly, stable and older versions) and source code so you can choose a specific commit paste it with bob install <commit hash> and it will build it for you.

from bob.

Ciel-MC avatar Ciel-MC commented on June 2, 2024

Yeah, and I was hoping there can be a "version name"(like stable or nightly) for the latest commit, like even faster than nightly, because now if I manually set the latest commit to my version, it doesn't update with bob update because it is pinned.

from bob.

MordechaiHadad avatar MordechaiHadad commented on June 2, 2024

So you want an alias for the last commit when running bob install?

from bob.

Ciel-MC avatar Ciel-MC commented on June 2, 2024

So you want an alias for the last commit when running bob install?

I guess you can say an alias? But also when you do bob update, it installs the latest commit(like latest and nightly)

from bob.

MordechaiHadad avatar MordechaiHadad commented on June 2, 2024

What would you call this alias?

from bob.

Ciel-MC avatar Ciel-MC commented on June 2, 2024

I figured git would be a good name, similar to how AUR repos call it

from bob.

max397574 avatar max397574 commented on June 2, 2024

Imo there is no need for this feature. Just wait for maximum 24 hours and then do bob install nightly. If you really want a feature just use the commit hash to install that specific commit.
KISS

from bob.

Ciel-MC avatar Ciel-MC commented on June 2, 2024

I had this debate with myself as well, but the thing for me is that it's often not just this one time I want to do it(so I install the latest manually, uninstall tomorrow and update nightly), I would prefer if I could stay on the latest commit easily as you can with stable and nightly, at least personally, found it to be barely make past the -100 pts, plus it's not a particularly difficult feature either, and maybe it will come in helpful in the future.

Sorry, long sentences from me are very coherent, my point is, I think this is not complicated enough and is quite helpful when you need/want it, even if it's not often.

P.S. KISS is usually for designing systems, features typically use the -100pt rule

from bob.

max397574 avatar max397574 commented on June 2, 2024

even if "the official" KISS rule doesn't apply here
I'm always against adding features that bring no big advantage to the user but cause more complicated code (here new logic needs to be added to get the latest commit) and also would make the whole application more complicated (e.g. bigger help etc).

and if you waited for weeks for a pr to be merged you can easily wait a few more hours imo.

from bob.

MordechaiHadad avatar MordechaiHadad commented on June 2, 2024

🤔

from bob.

MordechaiHadad avatar MordechaiHadad commented on June 2, 2024

I will work on this, but it won't be a priority because it is slightly more complicated than expected

from bob.

NonlinearFruit avatar NonlinearFruit commented on June 2, 2024

Something like this works if you have a get-github-token command or equivalent.

AUTH="Authorization: token $(get-github-token)"
SHA="$(curl -s -H "$AUTH" -H "Accept: application/vnd.github.VERSION.sha" https://api.github.com/repos/neovim/neovim/commits/master)"
bob install "$SHA"

Using a script like this could be a middle ground if nightly's are to slow and bob doesn't have a latest commit alias

from bob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.