Extra mouse buttons crash the click listener on Linux about pynput HOT 7 CLOSED

Thank you for the report.

For ease of use, mouse buttons are defined in an enum, so arbitrary values are not supported. I think an acceptable solution would be to:

• Add UNKNOWN to the base button class---this server as documentation only---and all platform implementations.
• Wrap creation of button values for listeners in a method that returns UNKNOWN when lookup fails.
• Add missing buttons to the Xorg backend.

You are more than welcome to submit a pull request to fix this issue. If you do, please run python setup.py lint with master checked out before, and then once afterwards to ensure that you do not introduce linter errors. I will merge well documented code quickly!

If you prefer to wait, I will fix this issue next week, as I am going on vacation tomorrow.

from pynput.

Looking at the code, wrapping creation of button values may be a bit pointless, since only the Xorg backend blindly transforms values this way.

from pynput.

I pushed a proposed solution to fixup-unknown-mouse-buttons.

It simply adds new button constants---rather hacky, but I much prefer to use an enum for mouse buttons for consistency---and falls back on Button.unknown for unknown buttons.

Since I don't have access to a fancy mouse, I need your help to test it. Could you please pull down the fixup branch and:

• Check out 5602a65fe3ced12c9357a4e1301b818c2d9de57b and verify that you get Button.button8 when you press the offending button.
• Check out 50378d51a40fc4147f838b9e9ba7c8a69f4e8b6b and verify that you get Button.unknown when you press the offending button.

Thank you in advance.

from pynput.

Oh I completely missed your earlier messages, so I didn't work on a fix. Thanks for pushing that, I'll test it when I get back to my computer later today!

from pynput.

I just tested with a few extra mouse buttons and everything works as expected on the latest on the fixup branch. Did you want me to test the individual commits?

Here's the output of testing 8, 9, 10 and 11.

In [1]: from pynput import mouse

In [2]: with mouse.Listener(on_click=lambda e,f,g,h: print(e,f,g,h)) as l: l.join()
682 883 Button.button8 True
682 883 Button.button8 False
680 881 Button.button9 True
692 872 Button.button9 False
654 881 Button.unknown True
654 881 Button.unknown False
649 879 Button.unknown True
649 879 Button.unknown False

from pynput.

Thank you!

The reason I wanted you to test two commits was that I wanted to check that the fallback to Button.unknown works---I certainly didn't expect your mouse to have more than eight buttons!

But it seems to work, so I'll merge the branch and make a new release.

from pynput.

Awesome, thanks for responding and fixing this! I've really liked using this library so far, it's quite easy to work with.

from pynput.