Add a dangerous_limit paramter for WithCPUDump method about holmes HOT 8 CLOSED

Heap Dump has the same scene.

"pprof is safe to use in production. We target an additional 5% overhead for CPU and heap allocation profiling. "

from holmes.

It's a good idea, and I prefer the latter too, we could configure not any CPU，but also mem and goroutine etc.
PR welcome!

from holmes.

in my previous experiments, if goroutine num is huge, eg. 100k
goroutine dump will also become a heavy action: stw && stack dump
maybe the goroutine number limit param should also be added~

from holmes.

in my previous experiments, if goroutine num is huge, eg. 100k goroutine dump will also become a heavy action: stw && stack dump maybe the goroutine number limit param should also be added~

how we measure this parameter, I mean it's difficult to have a common goroutine number limit on different machines, unlike CPU or memory can be measured in percent.

from holmes.

in my previous experiments, if goroutine num is huge, eg. 100k goroutine dump will also become a heavy action: stw && stack dump maybe the goroutine number limit param should also be added~

how we measure this parameter, I mean it's difficult to have a common goroutine number limit on different machines, unlike CPU or memory can be measured in percent.

Yes, it's hard to configure a universal value for every type of application load, if some users use this lib in their own app, maybe they can figure out a proper value with consideration on their own type of workload? I'm not sure

from holmes.

@cch123 ok, I will create a new pr, but before that, I want to discuss does this parameter control only goroutine profile dumping or all types profile dumping?

in other words,
change EnableDump

from holmes.

@cch123 ok, I will create a new pr, but before that, I want to discuss does this parameter control only goroutine profile dumping or all types profile dumping?

in other words, change EnableDump

holmes/holmes.go

Line 155 in 04a2f16

if err := h.EnableDump(cpu); err != nil {

or change

holmes/holmes.go

Line 168 in 04a2f16

func (h *Holmes) goroutineCheckAndDump(gNum int) {

only setting limit on goroutineCheckAndDump is ok, be careful about the naming~

from holmes.

In my opinion, if this goroutine parameter control all types profile dumping, use global EnableDump and WithCPUMax modify to WithMaxLimit(cpu, mem, goroutine), else control only goroutine profile, change to WithGoroutineDump(min int, diff int, abs int, max int).

from holmes.