Comments (4)
Interesting! Might be a bug — will look at it next week.
from delaunator-rs.
The reference implementation (Delaunator in JavaScript) works fine on that input, so must be something off in the port.
from delaunator-rs.
I've been getting the same issue while trying out this library. It makes it impossible to use for my purpose since it involves lots of calls with moving points. It seems I can only loop a few thousand times on average before it hits this and crashes.
From what I can tell the cause is on line 232:
Lines 230 to 235 in 82ddbdb
e
at this point will be -1, or EMPTY
, and instead of handling the empty value it instead tries to index into the slice. I do not know enough about the algorithm to know what is causing this, so I'm not sure if a simple empty check would suffice.
from delaunator-rs.
@mourner - whenever you get some time, do you think you could do a package release on crates.io with this fix? I use this crate on my library and I'd love to be able to reference the package version with this fix. Let me know if I can help in any way. Thank you!
from delaunator-rs.
Related Issues (16)
- Algorithm fails to generate correct Delaunay triangulation HOT 7
- no_std support HOT 1
- Triangulation.hull clock-wise instead of counter-clockwise? HOT 2
- Switch to GitHub Actions for CI
- Master ticket for fixes that need to be ported to match Delaunator HOT 4
- A disconnected triangulation may be generated HOT 1
- Either the algorithm does not generate valid triangles, or I am missing something HOT 1
- Incorrect hull for points on a square pattern HOT 1
- Filtering out new convex hull geometry? HOT 2
- sort_unstable_by has no fallback to equal HOT 4
- Add an `update` method for use in iterative algorithms
- Robustness questions HOT 1
- Accept other number types HOT 4
- Proper tests HOT 1
- unstable_sort_by panics when given NaN HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delaunator-rs.