Giter VIP home page Giter VIP logo

Comments (3)

mourner avatar mourner commented on July 24, 2024

Yeah, I agree. The reason it is done as it is right now is the simplicity of not having to introduce the concept of ids for items, and the performance benefit of array.indexOf(item) vs loop through comparing ids.

from rbush.

twpayne avatar twpayne commented on July 24, 2024

ol3's port of rbush stores the extent of each item added in a separate object, allowing items to be removed without knowing their extents. This is also useful for updating the rbush when the extent has changed:
https://github.com/openlayers/ol3/blob/vector-api/src/ol/structs/rbush.js#L577-589

from rbush.

calvinmetcalf avatar calvinmetcalf commented on July 24, 2024

so for background I was adding a geojson wrapper around rbush and more or less doing the same thing as open layers, calculating the bbox and inserting that and using a WeakMap to connect the objects to their extent, but I realized that this makes jsonifing unworkable, I'm thinking about how to rework it in a way that makes CRUD operations on rbush doable without direct references to the object.

Being able to add a comparator functions might be a good first step, but only if we could figure out how to do it in a way that didn't piss all over performance.

from rbush.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.