I'm considering a breaking API change that will make RBush more performant, but also m

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url

The latest commit in <a class="issue-link js-issue-link" data-error-text="Failed to lo

Object-based API about rbush HOT 6 CLOSED

mourner commented on June 25, 2024 1

Object-based API

from rbush.

Comments (6)

IvanSanchez commented on June 25, 2024 1

~~@mourner I've tried to run the perf tests on FFX 46 (using the memory-perf branch @760a69b), but got the following error:~~

@mourner I've run the perf tests on FFX 46 and node v4.4.3 (using the memory-perf branch @782f05c), and the results are encouraging as well:

                            FFX 46     FFX 46      Node4.4.3  Node4.4.3
                            master   memory-perf     master  memory-perf

insert one by one:        3433.73ms   2072.36ms      3792ms     2989ms
1000 searches 10%:        5803.59ms   3028.95ms      1842ms     1537ms
1000 searches 1%:          616.49ms    437.36ms       365ms      271ms
1000 searches 0.01%:        57.58ms     31.21ms        41ms       26ms
remove 1000 one by one:     17.26ms     13.81ms        15ms       13ms
bulk-insert 1M more:      1042.14ms     432.7ms      1264ms      962ms
1000 searches 1%:         1166.48ms    820.88ms       627ms      474ms
1000 searches 0.01%:        94.59ms     58.78ms        70ms       49ms

from rbush.

mourner commented on June 25, 2024

The latest commit in #45 should make insertion 10% faster on top of this. So looks like the change is definitely worth breaking the API.

from rbush.