Bit weird that a non-stubbed provider still pulls in data for stubbed response about moya HOT 3 CLOSED

Well, when we said that stubbed data would be a first-class citizen, we really meant it!

It is strange that the Endpoint requires the sample data for creation, which could impact the memory footprint of a production app if the sample data is large or there are many network requests at once (since an Endpoint instance with its own data is created for each network request).

I think that this is important enough to warrant inclusion in a 1.0 release. My thoughts on solving it are to change the EndpointSampleResponse.Success type to not include an NSData field, but instead a closure that returns an NSData instance. That way it won't be evaluated for non-stubbed providers and won't take up memory. Does that sound good?

from moya.

yes, the closure makes sense

from moya.

This is fixed with the new .Closure type of the sample response enum 👍

from moya.