Giter VIP home page Giter VIP logo

Comments (5)

data-sync-user avatar data-sync-user commented on June 15, 2024

➤ Alexandru Farcasanu commented:

Norberto Andres Furlan

Quick question here.

Do we need to change the localization text here? (Search Syncronised Tabs). As I can see in the code, there are 2 translations for this switch title. For en-GB is Search Synchronised Tabs and for en-US is already Search Synced Tabs.

In Figma file, may be the US version and in the screenshot from Attachments, is the GB one.

from firefox-ios.

data-sync-user avatar data-sync-user commented on June 15, 2024

➤ Norberto Andres Furlan commented:

Diana Andreea Barladeanu can you check this? I think it is ok if English US is Sync Tabs as we have in the design, but the English-UK was translated like Syncronised (that I think it is the english UK version). How we can request a translation review? Thanks!

from firefox-ios.

data-sync-user avatar data-sync-user commented on June 15, 2024

➤ Diana Andreea Barladeanu commented:

Hello, Delphine Lebedel, could you please help us with an opinion on this situation? 🙂

Thanks in advance!

cc Norberto Andres Furlan Alexandru Farcasanu

from firefox-ios.

data-sync-user avatar data-sync-user commented on June 15, 2024

➤ Delphine Lebedel commented:

Hi and thanks for flagging!

en-US strings are expected to stay as is, and other locales (such as en-GB, which is “English-UK” ) may wish to translate to something more appropriate to their language and culture. I checked on Pontoon (our Translation Management System) and indeed that is the way the localizer chose to translate.

So this should be all good 🙂

from firefox-ios.

data-sync-user avatar data-sync-user commented on June 15, 2024

➤ Alexandru Farcasanu commented:

No changes need to be done here!
Closed!

from firefox-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.