Channels should expire if flow does not complete within a reasonable timeframe about channelserver HOT 5 CLOSED

+1; I wonder if it would be more useful to frame it as "channels expire after X minutes of inactivity" rather than have it specifically be about waiting for the second device to connect, as this will help guard against flows that get abandoned part-way through

from channelserver.

I think the server already does this: https://github.com/mozilla-services/channelserver/blob/master/channelserver/src/server.rs#L129

I'd prefer if the timeout was actually a lot less than 15 minutes, to be honest. Heck, might even want to display a countdown timer.

One thing I'd very much like to avoid is the channelserver retaining knowledge of recently expired channels. Currently, if a channel is connected and there's no counterpart, there's simply no communications performed. For the initiating channel request, that should be preferred, for the connecting request, not getting a response back should fail pretty fast.

from channelserver.

if party.started.elapsed() <--- this line is a winner

"channels expire after X minutes of inactivity

I think it's reasonable to frame this way.

from channelserver.

@jrconlin the PR wasn't linked here, but I think this was fixed right?

from channelserver.

Yes, it was closed as part of #31. My apologies for missing it in the commit message.

from channelserver.